fix: do not remove contents from Schleuder ML messages #5149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
link2xt
force-pushed
the
link2xt/schleuder
branch
from
1069fc8 to
a3b0f4a
Compare
iequidoo
approved these changes
Jan 5, 2024
| fn maybe_remove_inline_mailinglist_footer(&mut self) { | ||
| if self.is_mailinglist_message() { | ||
| if self.is_mailinglist_message() && !self.is_schleuder_message() { |
There was a problem hiding this comment.
Do they never add footer as a third part?
There was a problem hiding this comment.
So far I only have one such list and received only unencrypted messages, so added one as an example. As I encounter more problems with it I can add more tests, but so far I have not seen signature text part.
Before this fix actual contents of the message reposted by Schleuder is considered a mailing list footer and removed, not visible even in the "Show Full Message..." view. With this change there will be two message bubbles, one for header and one for the contents, but it is still better than losing the contents completely. Attempting to parse header part is out of scope for this change.
link2xt
force-pushed
the
link2xt/schleuder
branch
from
a3b0f4a to
da11542
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this fix actual contents of the message
reposted by Schleuder is considered a mailing list footer and removed, not visible even in the "Show Full Message..." view.
With this change there will be two message bubbles, one for header and one for the contents,
but it is still better than losing the contents completely.
Attempting to parse header part is out of scope for this change.