-
-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use new experimental maps integration #3005
Conversation
usually, we do not check in some special submodules, as this tends to have issues on merging EDIT: but i updated core on |
another thing that needs to be considered, webxdc only works on android 5+ so maybe we should take the opportunity to remove the experimental option, enable maps in all platforms and disable them in android <5 |
i think, at least for 1.46, we will stay as experimental, this gives us room for changes (as this one :) i am also not really happy with the top-level UI elements: they clutter the chat always, but are needed only rarely and only in few chats. this is solved better on iOS. but then again, as long as it is experimental it's fine. i am not suggesting to change them now, it depends also on other features - eg. a "send position once" is still missing, and also a "show on map" deep link (for that, maybe wait until we have deep links on webxdc) and yes, the map will only be available on android5+, that's a reasonable tradeoff |
To test the changes in this pull request, install this apk: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code of integration looks good to me, only two minors, thanks a lot!
question is now if the new maps.xdc
is good enough to replace the old mapbox map - on iOS the decision was easier as there was just no map
what's missing:
- go to own position (however, was also not really available before)
- show all past tracks beyond 24h
we plan to add that, and improve even beyond, but we cannot make promises about timing. then, we're still experimental
whats new/nicer from the view of the user already now:
- nicer layout
- POI always show labels
- lots of POI and positions are shown much faster
- lots of POI are summed up nicely as the PNG is optimised for that
- you see the age of a position directly on the map (no longer you run to a bar 🍺 then noticing the position was from 10h ago)
4 mb smaller apkit is even 8mb smaller! just build main with and without the commit to change to maps.xdc - the .apk goes down from 59mb to 51mb
from the view of the dev, main advantage is that we can now iterate over on already two platforms. and wooooah: 2000+ lines boilerplate removed!111!!!one!eleven
so, i would vote for merging it to move forward, even if there is some temporary worsening for some ppl
Co-authored-by: bjoern <[email protected]>
Co-authored-by: bjoern <[email protected]>
+1 also less problems / bad karma with fdroid etc :) |
what is missing is checking latest core release tag in the submodule, I was not sure how it is usually done?
counterpart of deltachat/deltachat-ios#1912, uses deltachat/deltachat-core-rust#5461