Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Self-reporting, Android UI #2910

Merged
merged 1 commit into from
Feb 7, 2024
Merged

Self-reporting, Android UI #2910

merged 1 commit into from
Feb 7, 2024

Conversation

Hocuri
Copy link
Collaborator

@Hocuri Hocuri commented Dec 28, 2023

Copy link

To test the changes in this pull request, install this apk:
📦 app-preview.apk

@@ -93,6 +93,9 @@
android:title="@string/videochat_instance"
android:summary="@string/none"/>

<Preference android:key="pref_self_reporting"
android:title="Send statistics to Delta Chat's developers"/>
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that this is not translated yet

@Hocuri Hocuri changed the title [WIP] Self-reporting, Android UI Self-reporting, Android UI Jan 15, 2024
@Hocuri Hocuri requested review from adbenitez and r10s January 15, 2024 19:08
@@ -183,6 +186,22 @@ public void onCreate(Bundle paramBundle) {
}
return true;
});

Preference selfReporting = this.findPreference("pref_self_reporting");
selfReporting.setOnPreferenceClickListener(((preference) -> {
Copy link
Member

@adbenitez adbenitez Jan 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so they have to manually send them, from time to time 🤔 sounds inconvenient

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I wanted to start with something simple. We can always make things more complicated, and since for now this will only be implemented in Android (and not the other UIs), we can easily change the core API.

@adbenitez
Copy link
Member

adbenitez commented Jan 31, 2024

btw I think it is better to share as .txt file instead of a plain message user can accidentally or intentionally alter format and stats

Copy link
Member

@r10s r10s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good, smart thing to start with!

things as text vs. attachment etc. can be changed in core, discussions and some pros and cons are at deltachat/deltachat-core-rust#5129

@r10s r10s added the wait-for-core Issue/PR is waiting for core release label Feb 6, 2024
@Hocuri Hocuri merged commit 81b321f into main Feb 7, 2024
2 checks passed
@Hocuri Hocuri deleted the hoc/self-reporting branch February 7, 2024 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wait-for-core Issue/PR is waiting for core release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants