-
-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Self-reporting, Android UI #2910
Conversation
To test the changes in this pull request, install this apk: |
@@ -93,6 +93,9 @@ | |||
android:title="@string/videochat_instance" | |||
android:summary="@string/none"/> | |||
|
|||
<Preference android:key="pref_self_reporting" | |||
android:title="Send statistics to Delta Chat's developers"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that this is not translated yet
@@ -183,6 +186,22 @@ public void onCreate(Bundle paramBundle) { | |||
} | |||
return true; | |||
}); | |||
|
|||
Preference selfReporting = this.findPreference("pref_self_reporting"); | |||
selfReporting.setOnPreferenceClickListener(((preference) -> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so they have to manually send them, from time to time 🤔 sounds inconvenient
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I wanted to start with something simple. We can always make things more complicated, and since for now this will only be implemented in Android (and not the other UIs), we can easily change the core API.
btw I think it is better to share as .txt file instead of a plain message user can accidentally or intentionally alter format and stats |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good, smart thing to start with!
things as text vs. attachment etc. can be changed in core, discussions and some pros and cons are at deltachat/deltachat-core-rust#5129
Depends on deltachat/deltachat-core-rust#5129
Part of #2909