[Spark] Fix Utils.isTesting calls to use Delta implementation #4074
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Delta project/connector is this regarding?
Description
Some classes were using the
org.apache.spark.util.Utils
instead of theorg.apache.spark.sql.delta.util.Utils
The Spark implementation uses the SPARK_TESTING environment variable, while the Delta implementation uses the DELTA_TESTING key.
Spark:
https://github.com/apache/spark/blob/51fb84a54982719209c19136b1d72d2ef44726ee/core/src/main/scala/org/apache/spark/util/Utils.scala#L1878
Delta:
delta/spark/src/main/scala/org/apache/spark/sql/delta/util/Utils.scala
Line 58 in 221d95c
It means the unit tests are currently running non test code path, because we only set the DELTA_TESTING:
delta/build.sbt
Line 466 in 221d95c
delta/run-tests.py
Line 93 in 221d95c
How was this patch tested?
Unit tests
Does this PR introduce any user-facing changes?
No