Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: wrap future streams also in io_runtime #3162

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ion-elgreco
Copy link
Collaborator

@alamb pointed out that the get stream would be not executed on the IO runtime unless it was wrapped. So thanks to his example PR I've added this now for the other streams :) Thanks @alamb!

Also addressed some other missing areas where I should have enabled the IO runtime:

  • DeltaFileSystemHandler
  • Creating a table
  • Is Delta Table check
  • Writing a new table (used by pyarrow engine)
  • Writing a new table (rust engine)

I've also made it possible to pass an optional runtime in DeltaOps::try_from_uri, since this was missing but it seems a common used entry point to open a delta table

@github-actions github-actions bot added binding/python Issues for the Python package binding/rust Issues for the Rust crate labels Jan 25, 2025
@ion-elgreco
Copy link
Collaborator Author

@Tom-Newton can you give this a spin?

Copy link

codecov bot commented Jan 25, 2025

Codecov Report

Attention: Patch coverage is 12.57143% with 153 lines in your changes missing coverage. Please review.

Project coverage is 71.53%. Comparing base (f7745fd) to head (01da20b).

Files with missing lines Patch % Lines
crates/core/src/storage/mod.rs 0.00% 133 Missing ⚠️
crates/core/src/operations/mod.rs 40.00% 7 Missing and 2 partials ⚠️
python/src/lib.rs 0.00% 7 Missing ⚠️
crates/benchmarks/src/bin/merge.rs 0.00% 2 Missing ⚠️
crates/core/src/protocol/checkpoints.rs 66.66% 1 Missing ⚠️
python/src/filesystem.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3162      +/-   ##
==========================================
- Coverage   71.76%   71.53%   -0.23%     
==========================================
  Files         138      138              
  Lines       44362    44492     +130     
  Branches    44362    44492     +130     
==========================================
- Hits        31835    31829       -6     
- Misses      10495    10620     +125     
- Partials     2032     2043      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Ion Koutsouris <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
binding/python Issues for the Python package binding/rust Issues for the Rust crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant