DLPX-91971 linux-pkg: Add support for os-upgrade branches #320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
palash-gandhi
force-pushed
the
dlpx/pr/palash-gandhi/9a4d3e3e-1a25-46b0-994b-1a0bfe34b0a7
branch
5 times, most recently
from
a2df1c5 to
dbd5cdb
Compare
palash-gandhi
force-pushed
the
dlpx/pr/palash-gandhi/9a4d3e3e-1a25-46b0-994b-1a0bfe34b0a7
branch
from
dbd5cdb to
d81ce6e
Compare
palash-gandhi
force-pushed
the
dlpx/pr/palash-gandhi/9a4d3e3e-1a25-46b0-994b-1a0bfe34b0a7
branch
from
d81ce6e to
586cb7e
Compare
sebroy
approved these changes
Aug 27, 2024
palash-gandhi
force-pushed
the
dlpx/pr/palash-gandhi/9a4d3e3e-1a25-46b0-994b-1a0bfe34b0a7
branch
from
586cb7e to
d28c963
Compare
palash-gandhi
force-pushed
the
dlpx/pr/palash-gandhi/9a4d3e3e-1a25-46b0-994b-1a0bfe34b0a7
branch
from
d28c963 to
f37b478
Compare
sebroy
approved these changes
Aug 27, 2024
david-mendez1
approved these changes
Aug 28, 2024
palash-gandhi
deleted the
dlpx/pr/palash-gandhi/9a4d3e3e-1a25-46b0-994b-1a0bfe34b0a7
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Ubuntu version upgrade projects require an "os-upgrade" branch in product repositories. Instead of requiring this branch in each repository, we can make the linux-pkg framework use the "develop" branch if the "os-upgrade" branch of a package repository does not exist. This makes branch management slightly easier. This also means that "os-upgrade" branches must be deleted after use.
Solution
Add logic to use "develop" when "os-upgrade" does not exist while building the package.
Testing Done
challenge-response (has an "os-upgrade" branch): http://ops.jenkins-palashgandhi.dcol2.delphix.com/job/linux-pkg/job/os-upgrade/job/build-package/job/challenge-response/job/post-push/5/console.
Failures are expected due to pending fixes on the os-upgrade branch: https://github.com/delphix/challenge-response/pull/5
bcc (does not have an "os-upgrade" branch): http://ops.jenkins-palashgandhi.dcol2.delphix.com/job/linux-pkg/job/os-upgrade/job/build-package/job/bcc/job/post-push/5/console