Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TOOL-24368 Use grub packages provided by Ubuntu #306

Conversation

prakashsurya
Copy link
Contributor

@prakashsurya prakashsurya commented Jan 4, 2024

Context

We used to have a "boot counter" implemented in GRUB, such that we could detect "reboot loops" (e.g. repeated failures to boot) and automatically boot into an alternate root filesystem which we called the "recovery environment". We've since abandoned that feature, and thus, we can migrate back to using Ubuntu's grub package(s).

Additionally, this was sparked due to the sporadic GRUB boot failures we've seen on customer engines. While we don't have any evidence to support our locally modified of GRUB is causing the boot failures, this change eliminates this as a possibility, and gets us back to using the packages built and tested by Ubuntu.

Testing

  • git-ab-pre-push -b delphix-platform is here
  • Verified grub packages pulled from Ubuntu's mirror in the build above; e.g.
10:44:54  Get:240 http://linux-package-mirror.delphix.com/develop/dece9540/ubuntu focal-updates/main amd64 grub-common amd64 2.04-1ubuntu26.17 [1872 kB]
10:44:54  Get:241 http://linux-package-mirror.delphix.com/develop/dece9540/ubuntu focal-updates/main amd64 grub2-common amd64 2.04-1ubuntu26.17 [590 kB]
10:44:54  Get:242 http://linux-package-mirror.delphix.com/develop/dece9540/ubuntu focal-updates/main amd64 grub-pc-bin amd64 2.04-1ubuntu26.17 [971 kB]
10:44:54  Get:243 http://linux-package-mirror.delphix.com/develop/dece9540/ubuntu focal/main amd64 grub-gfxpayload-lists amd64 0.7 [3658 B]
10:44:54  Get:244 http://linux-package-mirror.delphix.com/develop/dece9540/ubuntu focal-updates/main amd64 grub-pc amd64 2.04-1ubuntu26.17 [125 kB]

@prakashsurya prakashsurya force-pushed the dlpx/pr/prakashsurya/09715bfe-0df8-4378-b4b1-f55bc9845dfd branch from d5511ec to bf6e956 Compare January 4, 2024 18:15
@prakashsurya prakashsurya marked this pull request as ready for review January 4, 2024 19:40
Copy link
Contributor

@sumedhbala-delphix sumedhbala-delphix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we feel comfortable pushing this 6 days before CC or are we better off integrating this as soon as 20.0 opens up?

@prakashsurya
Copy link
Contributor Author

do we feel comfortable pushing this 6 days before CC or are we better off integrating this as soon as 20.0 opens up?

I can wait for 20.0.. I think that's fine, and makes sense for a largely untested change like this.

@prakashsurya prakashsurya merged commit e865678 into develop Jan 16, 2024
17 checks passed
@prakashsurya prakashsurya deleted the dlpx/pr/prakashsurya/09715bfe-0df8-4378-b4b1-f55bc9845dfd branch January 16, 2024 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants