TOOL-24368 Use grub packages provided by Ubuntu #306
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
We used to have a "boot counter" implemented in GRUB, such that we could detect "reboot loops" (e.g. repeated failures to boot) and automatically boot into an alternate root filesystem which we called the "recovery environment". We've since abandoned that feature, and thus, we can migrate back to using Ubuntu's grub package(s).
Additionally, this was sparked due to the sporadic GRUB boot failures we've seen on customer engines. While we don't have any evidence to support our locally modified of GRUB is causing the boot failures, this change eliminates this as a possibility, and gets us back to using the packages built and tested by Ubuntu.
Testing
git-ab-pre-push -b delphix-platform
is here