DLPX-88225 Automated hotfix process leads to hotfix branch engine version always being set as latest engine version TOOL-23229 Improvements to masking/containerized-masking/virtualization linux-pkg handling #304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sonamkindy
force-pushed
the
dlpx/pr/sonamkindy/62bd47d9-7ad9-4023-8a11-73cc323747da
branch
2 times, most recently
from
8a7cf52 to
88c5368
Compare
sonamkindy
changed the title
sonamkindy
force-pushed
the
dlpx/pr/sonamkindy/62bd47d9-7ad9-4023-8a11-73cc323747da
branch
from
88c5368 to
ebbc897
Compare
sonamkindy
changed the title
sonamkindy
force-pushed
the
dlpx/pr/sonamkindy/62bd47d9-7ad9-4023-8a11-73cc323747da
branch
from
ebbc897 to
94cfb3b
Compare
…sion always being set as latest engine version TOOL-23229 Improvements to masking/containerized-masking/virtualization linux-pkg handling PR URL: https://www.github.com/delphix/linux-pkg/pull/304
sonamkindy
force-pushed
the
dlpx/pr/sonamkindy/62bd47d9-7ad9-4023-8a11-73cc323747da
branch
from
94cfb3b to
a46c957
Compare
sebroy
reviewed
Oct 19, 2023
sebroy
approved these changes
Oct 19, 2023
prakashsurya
approved these changes
Oct 19, 2023
sonamkindy
deleted the
dlpx/pr/sonamkindy/62bd47d9-7ad9-4023-8a11-73cc323747da
branch
sandeep-delphix
pushed a commit
that referenced
this pull request
Mar 27, 2024
…sion always being set as latest engine version TOOL-23229 Improvements to masking/containerized-masking/virtualization linux-pkg handling (#304) PR URL: https://www.github.com/delphix/linux-pkg/pull/304
sandeep-delphix
pushed a commit
that referenced
this pull request
Jun 12, 2024
…sion always being set as latest engine version TOOL-23229 Improvements to masking/containerized-masking/virtualization linux-pkg handling (#304) PR URL: https://www.github.com/delphix/linux-pkg/pull/304
bhavinee-jadav
pushed a commit
that referenced
this pull request
Jun 18, 2024
…sion always being set as latest engine version TOOL-23229 Improvements to masking/containerized-masking/virtualization linux-pkg handling (#304) PR URL: https://www.github.com/delphix/linux-pkg/pull/304
sandeep-delphix
pushed a commit
that referenced
this pull request
Jun 19, 2024
…sion always being set as latest engine version TOOL-23229 Improvements to masking/containerized-masking/virtualization linux-pkg handling (#304) PR URL: https://www.github.com/delphix/linux-pkg/pull/304
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
DLPX-88225
The earlier change checked into dms-core-gate at https://github.com/delphix/dms-core-gate/pull/251 unfortunately introduced a slew of issues, including the automated hotfix process not picking up the right engine version for the given hotfix.
TOOL-23229
We should reduce repetition when it comes to passing the secret build args needed to fetch secrets from the AWS secret store.
Solution
DLPX-88225
The environment variable
DELPHIX_RELEASE_VERSIONis what we actually care about - if that's set, we can directly pass it as a gradle property via the gradle command (that way, the dms-core-gate get-branch-version.sh shell script doesn't get executed at all).TOOL-23229
Add a function in
lib/common.shthat can be used by the virtualization, masking and containerized-masking linux-pkg jobs.Testing Done
http://selfservice.jenkins.delphix.com/job/appliance-build-orchestrator-pre-push/7291/