Refine the wording of the entry of full disk encryption during instal… #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
superm1
reviewed
Sep 20, 2019
debian/dell-recovery.templates
Outdated
|
|
||
| Template: ubiquity/text/interactive_info | ||
| Type: text | ||
| _Description: This option allows you to resize any existing partitions. | ||
| _Description: e.g. Disk encryption, partitions resizeing..etc. |
There was a problem hiding this comment.
typographical error; resizing not resizeing
superm1
reviewed
Sep 20, 2019
ubiquity/stepDellBootstrap.ui
Outdated
| @@ -544,7 +544,7 @@ | |||
| <property name="can_focus">False</property> | |||
| <property name="xalign">0</property> | |||
| <property name="yalign">0</property> | |||
| <property name="label" translatable="yes">This option allows you to resize any existing partitions.</property> | |||
| <property name="label" translatable="yes">e.g. Disk encryption, partitions resizeing..etc.</property> | |||
|
Conceptually a good idea. I think we should merge it once you fix the two typos. Two thoughts that we should keep in mind though:
|
alex-tu-cc
force-pushed
the
refine-wording
branch
from
e7fd1c8 to
f293a05
Compare
|
thanks for reviewing. The typo has been revised. |
superm1
approved these changes
Sep 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refine the wording of the entry of full disk encryption during installation
Because of the wording is confusing people to find out an entry to do full disk encryption, so this patch is to refine it.
before:
http://i.imgur.com/GVgCzwZ.png
after:
http://i.imgur.com/g08SLbs.png