Node 20 for master/1.X branch #77
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbradydeliverr
requested review from
ankit-deliverr and
platform-deliverr
and removed request for
a team
![cycode-security[bot]](https://avatars.githubusercontent.com/in/39308?s=60&v=4){kind=small}
Wiz Scan Summary
To detect these findings earlier in the dev lifecycle, try using Wiz Code VS Code Extension. |
Wiz Scan Summary
To detect these findings earlier in the dev lifecycle, try using Wiz Code VS Code Extension. |
mbradydeliverr
commented
Sep 27, 2024
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "knex-snowflake-dialect", | |||
| "version": "1.0.3", | |||
| "version": "1.1.0", | |||
There was a problem hiding this comment.
Explicitly bumped new minor since circleci will only automatically do patch versions
mbradydeliverr
commented
Sep 27, 2024
| @@ -72,9 +72,14 @@ | |||
| "sinon": "9.0.1", | |||
| "sinon-chai": "3.5.0", | |||
| "ts-jest": "25.2.1", | |||
| "tslint": "6.1.0", | |||
| "tslint": "^5.20.1", | |||
There was a problem hiding this comment.
downgraded due to peer dependency conflict
mbradydeliverr
commented
Sep 27, 2024
| "tslint-config-prettier": "1.18.0", | ||
| "tslint-microsoft-contrib": "6.2.0", | ||
| "typescript": "^4.3.4" | ||
| }, | ||
| "overrides": { |
There was a problem hiding this comment.
Needed to override due to tslint-microsoft-contrib saying it only supports typescript@3
mbradydeliverr
commented
Sep 27, 2024
There was a problem hiding this comment.
These rules weren't even working, probably due to the wrong peer dependencies. I opted to disable the rules instead of trying to fix all the warnings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.