Knex update #43
Open
Knex update #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
June 27, 2022 10:59
HaTiIn
requested review from
emurphy,
karstendick,
stewartb-deliverr,
diogenes-deliverr,
eihli and
udit-deliverr
as code owners
added 2 commits
July 5, 2022 10:16
Knex returns native JS promises instead of Bluebird ones. This means that you no longer use such methods as `map`, `spread` and `reduce` on QueryBuilder instance.
|
Anyone? |
|
I was about to make a PR for this also, we are going to have to fork in the meantime. |
|
Updated to knex 2.3.0 |
# Conflicts: # package-lock.json
|
Updated to knex 2.4.2 |
|
Can somebody please review my pull request? |
|
I don't really have any domain knowledge here...we just pointed our I will say we did that 9+ months ago and haven't run into any issues with the stuff we are doing (mainly raw query building). |
|
Could anyone have a look at this? We are also running our tests against this branch for a couple of monthes. |
schmetzyannick
requested review from
kklein-deliverr
and removed request for
diogenes-deliverr,
stewartb-deliverr,
udit-deliverr and
a team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates knex to 2.1.0 and fixes some issues