[im-2290] Instrument timeout exceptions #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anujc4
changed the title
smnalex
reviewed
May 22, 2024
| @@ -22,6 +22,9 @@ def call(request_env) | |||
| rescue Routemaster::Errors::BaseError => e | |||
| increment_response_count(response_tags(e.env)) | |||
| raise e | |||
| rescue Faraday::TimeoutError => e | |||
There was a problem hiding this comment.
(If the circuit is open we won't report any metrics)
There was a problem hiding this comment.
Yep, but we would know how many timeouts we received before the breaker was tripped. We anyway don't push any metric once a circuit trips. We would have to record circuitbox metrics for that information.
smnalex
reviewed
May 22, 2024
| @@ -22,6 +22,9 @@ def call(request_env) | |||
| rescue Routemaster::Errors::BaseError => e | |||
| increment_response_count(response_tags(e.env)) | |||
| raise e | |||
| rescue Faraday::TimeoutError => e | |||
There was a problem hiding this comment.
Should we add connection too?
There was a problem hiding this comment.
Wdym? Routemaster::Errors::BaseError and Faraday::TimeoutError are the only exceptions that are monitored by CircuitBox
There was a problem hiding this comment.
I meant Faraday::ConnectionFailed, but sorry, forgot that you made this change only for CB.
smnalex
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DESCRIPTION
JIRA Ticket: im-2290
CHANGELOG:
Instrument timeout exceptions. There are a few tests failing on the PR, but these are unrelated to my changes and have been failing on the CI for some time now.