Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs:add eirafontanals in the README #42

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

docs:add eirafontanals in the README #42

wants to merge 2 commits into from

Conversation

eirafontanals
Copy link
Collaborator

@eirafontanals eirafontanals commented Sep 14, 2023 •
edited
Loading

This PR closes #22
Add my name, my GitHub account link and a sentence that defines me.

@eirafontanals eirafontanals linked an issue Sep 14, 2023 that may be closed by this pull request
Introducing Myself (eirafontanals) #22
Open
@eirafontanals eirafontanals self-assigned this Sep 14, 2023
@eirafontanals eirafontanals added documentation Improvements or additions to documentation and removed documentation Improvements or additions to documentation labels Sep 14, 2023
deliaBlue
deliaBlue previously requested changes Sep 14, 2023
View reviewed changes
Copy link
Owner

@deliaBlue deliaBlue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! Hope you did it with Vim :)

Just one small thing, the first line in the PR description must be:

This PR closes #YOUR_ISSUE_NUMBER.

Description of the changes

README.md Outdated Show resolved Hide resolved
AlbaJimLup
AlbaJimLup requested changes Sep 14, 2023
View reviewed changes
Copy link
Collaborator

@AlbaJimLup AlbaJimLup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! just one small change and you are ready to merge

README.md Outdated Show resolved Hide resolved
AlbaJimLup
AlbaJimLup approved these changes Sep 15, 2023
View reviewed changes
Copy link
Collaborator

@AlbaJimLup AlbaJimLup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! all ready to merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlbaJimLup AlbaJimLup AlbaJimLup approved these changes

@deliaBlue deliaBlue deliaBlue left review comments

Assignees

@eirafontanals eirafontanals

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Introducing Myself (eirafontanals)
3 participants
@eirafontanals @deliaBlue @AlbaJimLup