docs: add JJS1440 in the README #41
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlbaJimLup
requested changes
Sep 14, 2023
There was a problem hiding this comment.
Great job overall! Just some minor changes:
The name of the pull request should be "docs: add your_user_name in the README" you can change this in "Edit" on the top right of the pull request.
Inside the description of the pull request please state "This PR closes #number", where number is the number of you issue
Additionally, the commit should be something along the lines of "docs: add sentence and git profile link". Do this for you next commit after you do the changes.
AlbaJimLup
requested changes
Sep 14, 2023
AlbaJimLup
requested changes
Sep 15, 2023
AlbaJimLup
approved these changes
Sep 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #30