@carmensat in the README #38
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diego-benito-j
requested changes
Sep 14, 2023
There was a problem hiding this comment.
Great job!
This was nearly perfect - the body of your commit should start with something along the lines of This PR closes #12 because the issue isn't solved yet!
See the comments below on your proposed file changes.
After that, proceed to save your the modified file locally, following the git README to make sure these changes are reflected in your branch again (i.e the add commit and push process).
|
Seems you did not as for a re-review, please, change the PR title with the format specified and ask the review so Diego can approve your PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solved issue #12
I have added Carmen Samedi to the junior contributors and added an extra sentence.