Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add Jan Izquierdo junior collaborator #32

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

docs: add Jan Izquierdo junior collaborator #32

wants to merge 5 commits into from

Conversation

Janek21
Copy link
Collaborator

@Janek21 Janek21 commented Sep 13, 2023 •
edited
Loading

Issue #1 can be closed.
Changes: added name, github user and a short phrase has been added

@Janek21 Janek21 self-assigned this Sep 13, 2023
@Janek21 Janek21 linked an issue Sep 13, 2023 that may be closed by this pull request
Introducing Myself(Janek21) #1
Open
@Janek21 Janek21 changed the title test:Jan Izquierdo test commit docs: add Jan Izquierdo junior collaborator Sep 13, 2023
@Janek21 Janek21 marked this pull request as draft September 13, 2023 17:25
@Janek21 Janek21 closed this Sep 13, 2023
@Janek21 Janek21 reopened this Sep 13, 2023
@deliaBlue
Copy link
Owner

Hey! Just seen you mark this PR as a draft. I think it is pretty ready to be merged if you feel confident about it. If so, put it back again as an active PR and request Diego a review clicking at the upper-right corner and set him as the reviewer.

@Janek21 Janek21 marked this pull request as ready for review September 14, 2023 07:15
@deliaBlue
Copy link
Owner

Thank you for adding me as a reviewer but that was not required. Your only reviewer will be Diego as he is in your group, that way in class both of you can comment anything if needed. I will left this PR for him to check.

@deliaBlue deliaBlue removed their request for review September 14, 2023 07:35
diego-benito-j
diego-benito-j approved these changes Sep 14, 2023
View reviewed changes
Copy link
Collaborator

@diego-benito-j diego-benito-j left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!
The only thing to mention is that the format of the initial commit was correct, since "This PR closes #1" is the appropriate formatting! Once you've merged, remember to delete your branch!

@Janek21
Copy link
Collaborator Author

Janek21 commented Sep 14, 2023 via email

@deliaBlue
Copy link
Owner

You can now merge this PR (after solving the conflicts). Sorry for the delay!

deliaBlue
deliaBlue approved these changes Sep 17, 2023
View reviewed changes
Copy link
Owner

@deliaBlue deliaBlue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank for your work :)!

deliaBlue
deliaBlue approved these changes Sep 17, 2023
View reviewed changes
Copy link
Owner

@deliaBlue deliaBlue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diego-benito-j diego-benito-j diego-benito-j approved these changes

@deliaBlue deliaBlue deliaBlue approved these changes

Assignees

@Janek21 Janek21

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Introducing Myself(Janek21)
3 participants
@Janek21 @deliaBlue @diego-benito-j