Fix slowness in delegate page #180
Conversation
Deploying delegit with
|
| Latest commit: |
678d8ff
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://4a069181.delegit.pages.dev |
| Branch Preview URL: | https://tbaut-usecallbacks.delegit.pages.dev |
|
The main issue was
If you type in the input now, it's instant. Before it took a sec for the text to appear. |
| aliceKeyPair.publicKey, | ||
| 'Sr25519', | ||
| aliceKeyPair.sign, | ||
| const aliceKeyPair = useMemo(() => derive('//Alice'), [derive]) |
There was a problem hiding this comment.
Not sure I understand this... derive (line 14) already uses useMemo. Why to reuse it?
There was a problem hiding this comment.
Because we don't need to derive every single render if derive doesn't change. So the aliceKeyPair will be derived once for all. Also I just memoize / useCallback everything at this point. Spending an hour to find the one function that makes everything slow is more time consuming than bluntly memoizing every single const IMHO. I used to do this in all my apps, chose not to be annoying for Delegit, and it bit us all the same. The experience of using the delegate page just got much much better thanks to this.
|
Thanks for the review, and sorry for the 1000 oversights of logs etc 😅 |
closes #151