Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed error parsing #179

Merged
merged 2 commits into from
Oct 2, 2024
Merged

fixed error parsing #179

merged 2 commits into from
Oct 2, 2024

Conversation

uDaiko
Copy link
Contributor

@uDaiko uDaiko commented Oct 1, 2024 •
edited
Loading

closes #147
Screenshot 2024-10-01 at 20 18 53

@uDaiko uDaiko requested review from wirednkod and Tbaut as code owners October 1, 2024 18:16
Tbaut
Tbaut approved these changes Oct 2, 2024
View reviewed changes
Copy link
Contributor

@Tbaut Tbaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this works well. Please just see my comment, there's no need of the quotes etc any more.

src/hooks/useGetSigningCallback.tsx Outdated Show resolved Hide resolved
@uDaiko
Copy link
Contributor Author

uDaiko commented Oct 2, 2024

Ah, such a simple oversight on my part sorry. Thanks for correcting it

@wirednkod wirednkod merged commit ad994c2 into delegit-xyz:main Oct 2, 2024
2 checks passed
@wirednkod
Copy link
Member

Thank you @uDaiko

@Tbaut
Copy link
Contributor

Tbaut commented Oct 2, 2024 •
edited
Loading

whoop amazing, our first outside contribution on this repo. Thank you @uDaiko ❤️

edit: ah no there was Tien before, but we know him :)

@uDaiko uDaiko deleted the cancel_errormessage branch October 8, 2024 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tbaut Tbaut Tbaut approved these changes

@wirednkod wirednkod wirednkod approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

No clear error when closing the Talisman popup
3 participants
@uDaiko @wirednkod @Tbaut