Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for pulling Spin OCI images #180

Merged
merged 3 commits into from
Nov 13, 2023
Merged

Conversation

jsturtevant
Copy link
Contributor

Replaces #164

Signed-off-by: James Sturtevant <[email protected]>
Copy link
Member

@Mossaka Mossaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

containerd-shim-spin/src/engine.rs Show resolved Hide resolved
Copy link
Member

@radu-matei radu-matei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this in a new k3d cluster with a Spin app published to a registry using spin registry push and everything works great!

Thank you so much for the work here!

containerd-shim-spin/quickstart.md Outdated Show resolved Hide resolved
Signed-off-by: James Sturtevant <[email protected]>
@Mossaka
Copy link
Member

Mossaka commented Nov 13, 2023

This can be a follow-up task. Could you please add at least one integration test for testing spin OCI images?

@Mossaka Mossaka merged commit b2d695c into deislabs:main Nov 13, 2023
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants