feat: add saml sso support as the default #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Racer159
approved these changes
May 24, 2024
oates
pushed a commit
that referenced
this pull request
May 25, 2024
🤖 I have created a release *beep* *boop* --- ## [17.0.1-uds.1](v17.0.1-uds.0...v17.0.1-uds.1) (2024-05-24) ### ⚠ BREAKING CHANGES * add saml sso support as the default ([#118](#118)) ([d1bc561](d1bc561)) > **NOTE:** The above change should convert existing instances from OIDC to SAML seamlessly, but will _require_ UDS Core v0.22.0 or higher. ### Miscellaneous * **deps:** update support-deps to v37.377.2 ([#134](#134)) ([028c3b8](028c3b8)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Wayne Starr <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds saml protocol support for SSO and sets it as the default. To go back to OIDC, set the value
sso.protocoltoopenid_connect(example inbundle/uds-config.yaml)Also, when
samlis set as the protocol, this also enables granting admin access to gitlab using keycloak group membership. By default, being a member of either/GitLab Adminor/UDS Core/Adminin keycloak will grant GitLab admin access.Related Issue
Relates to #102
Type of change
Checklist before merging