chore: add support for configurable admin domain #284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
mjnagel
commented
Dec 13, 2024
UnicornChance
approved these changes
Dec 13, 2024
mjnagel
added a commit
to defenseunicorns/uds-core
that referenced
this pull request
Dec 16, 2024
## Description Allows more flexibility in deployment by exposing a new zarf var for `ADMIN_DOMAIN`. Note that an entirely different domain will require this change in Keycloak: defenseunicorns/uds-identity-config#284 ## Related Issue N/A ## Type of change - [ ] Bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds functionality) - [x] Other (security config, docs update, etc) ## Steps to Validate Testing can be done by exporting `UDS_ADMIN_DOMAIN=uds.dev`. With these changes you should be able to see all virtualservices and gateways use `uds.dev`. Applications will not immediately be accessible due to uds-k3d's nginx config routing them to the wrong gateway (plus the wrong certs used for the admin interfaces). You can also test with a different domain entirely but this requires similar setup. ## Checklist before merging - [x] Test, docs, adr added or updated as needed - [x] [Contributor Guide](https://github.com/defenseunicorns/uds-template-capability/blob/main/CONTRIBUTING.md) followed --------- Co-authored-by: Chance <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Modifies the trusted hosts policy to match
"*.${UDS_ADMIN_DOMAIN}"instead of"*.admin.${UDS_DOMAIN}". Note that*.${UDS_DOMAIN}will also match*.admin.${UDS_DOMAIN}due to how Keycloak interprets these. In some cases both list items may be identical, but Keycloak allows this without issue.This should wait on the related PR in uds-core: defenseunicorns/uds-core#1114
Related Issue
N/A
Type of change
Checklist before merging