Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add action to check readiness on renovate PRs before running CI #1144

Merged
merged 1 commit into from
Dec 20, 2024

Conversation

mjnagel
Copy link
Contributor

@mjnagel mjnagel commented Dec 20, 2024

Description

Adds a new action that checks renovate PR readiness and fails CI before using the large runners if the PR is not ready. At this point the action just checks for a renovate-ready label, but this could be changed in the future to look for changes in the PR, etc.

Related Issue

Related to #168

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Steps to Validate

This functionality was validated on my fork due to some of the complexities around testing it on this repo. A demo/walkthrough can be provided by appointment.

Checklist before merging

@mjnagel mjnagel self-assigned this Dec 20, 2024
@mjnagel mjnagel requested a review from a team as a code owner December 20, 2024 17:49
Copy link
Contributor

@UnicornChance UnicornChance left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, in person review

@mjnagel mjnagel merged commit 83d81c6 into main Dec 20, 2024
18 checks passed
@mjnagel mjnagel deleted the renovate-ci-churn branch December 20, 2024 19:06
mjnagel pushed a commit that referenced this pull request Dec 20, 2024
🤖 I have created a release *beep* *boop*
---


##
[0.33.1](v0.33.0...v0.33.1)
(2024-12-20)


### Bug Fixes

* add generated target for all node IPs
([#1119](#1119))
([033338b](033338b))


### Miscellaneous

* add action to check readiness on renovate PRs before running CI
([#1144](#1144))
([83d81c6](83d81c6))
* **deps:** update codeql action to v3.28.0
([#1146](#1146))
([fe9bccf](fe9bccf))
* **deps:** update k8s-sidecar to v1.28.4
([#1132](#1132))
([b4f15ff](b4f15ff))
* **deps:** update loki
([#1134](#1134))
([56d0e39](56d0e39))
* **deps:** update prometheus-stack (prometheus 3.0.1, operator 0.79.2)
([#949](#949))
([5a35fc6](5a35fc6))
* **deps:** update support-deps
([#1131](#1131))
([4853969](4853969))
* **deps:** update support-deps
([#1138](#1138))
([2764d03](2764d03))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants