Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: grype scan custom action #353

Open
wants to merge 34 commits into
base: main
Choose a base branch
from
Open

Conversation

partkyle
Copy link

@partkyle partkyle commented Dec 5, 2024

Description

A reusable workflow for scanning all of the container images in a zarf.yaml file.

Checklist before merging

  • ADR proposed if making an architectural change to the repo
  • Tests run, docs added or updated as needed

@partkyle partkyle requested review from a team as code owners December 5, 2024 22:01
@zachariahmiller
Copy link
Contributor

zachariahmiller commented Dec 6, 2024

A few thoughts:

  1. I dont think this belongs in a dedicated callable workflow. In the future maybe there is a reason to add a "scan" workflow, but for now it should probably be part of lint.
  2. We should not rely on a github action to install grype, but rather a task. The grype install process (not using the action) should be added under tasks/actions.yaml
  3. This needs to be updated to support GitLab as well, which all the other common functions now do. The gitlab components are implemented under templates/
  4. I think its fine in a PR workflow to scan based on the zarf.yaml, which is the use case here. Just to note: in terms of anything speaking to posture of an actual published package it should happen from images actually present in the artifact, not based on the zarf.yaml as image tags arent necessarily immutable.

@partkyle
Copy link
Author

partkyle commented Dec 6, 2024

  1. We should not rely on a github action to install grype, but rather a task. The grype install process (not using the action) should be added under tasks/actions.yaml

I addressed this and the setup is in the actions.yaml file and has been removed from the github action.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants