Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: migrate exec behavior for maru #80

Merged
merged 39 commits into from
May 21, 2024
Merged

chore: migrate exec behavior for maru #80

merged 39 commits into from
May 21, 2024

Conversation

Racer159
Copy link
Contributor

@Racer159 Racer159 commented May 8, 2024 •
edited
Loading

Description

This migrates exec here in preparation of maru disconnecting itself from zarf.

Related Issue

Fixes #N/A

@Racer159 Racer159 marked this pull request as draft May 8, 2024 19:00
Noxsios
Noxsios requested changes May 9, 2024
View reviewed changes
exec/utils.go Outdated Show resolved Hide resolved
exec/shell.go Outdated Show resolved Hide resolved
exec/utils.go Outdated Show resolved Hide resolved
exec/go.mod Outdated Show resolved Hide resolved
exec/exec.go Outdated Show resolved Hide resolved
exec/exec.go Outdated Show resolved Hide resolved
exec/exec.go Show resolved Hide resolved
@Racer159 Racer159 self-assigned this May 9, 2024
AustinAbro321
AustinAbro321 requested changes May 15, 2024
View reviewed changes
Copy link
Contributor

@AustinAbro321 AustinAbro321 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love the added unit tests! Nice work

exec/exec.go Show resolved Hide resolved
variables/templates_test.go Outdated Show resolved Hide resolved
variables/templates_test.go Outdated Show resolved Hide resolved
@UncleGedd UncleGedd mentioned this pull request May 15, 2024
Merged
5 tasks
Noxsios
Noxsios requested changes May 15, 2024
View reviewed changes
variables/templates_test.go Outdated Show resolved Hide resolved
variables/templates_test.go Outdated Show resolved Hide resolved
variables/templates_test.go Outdated Show resolved Hide resolved
helpers/progress.go Outdated Show resolved Hide resolved
lucasrod16
lucasrod16 previously approved these changes May 17, 2024
View reviewed changes
Copy link
Contributor

@lucasrod16 lucasrod16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Racer159 Racer159 changed the title chore: migrate variables and exec behavior for maru chore: migrate exec behavior for maru May 17, 2024
Noxsios
Noxsios requested changes May 20, 2024
View reviewed changes
exec/exec.go Outdated Show resolved Hide resolved
.gitignore Outdated Show resolved Hide resolved
exec/shell.go Outdated Show resolved Hide resolved
exec/utils.go Outdated Show resolved Hide resolved
@Racer159 Racer159 requested a review from Noxsios May 20, 2024 15:41
Noxsios
Noxsios requested changes May 20, 2024
View reviewed changes
exec/shell_test.go Outdated Show resolved Hide resolved
exec/utils_test.go Outdated Show resolved Hide resolved
Noxsios
Noxsios requested changes May 20, 2024
View reviewed changes
exec/utils.go Show resolved Hide resolved
exec/utils.go Outdated Show resolved Hide resolved
exec/utils_test.go Outdated Show resolved Hide resolved
@Racer159 Racer159 requested a review from Noxsios May 20, 2024 19:09
AustinAbro321
AustinAbro321 approved these changes May 21, 2024
View reviewed changes
Copy link
Contributor

@AustinAbro321 AustinAbro321 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems strange to me that we're only allowing certain commands to be mutated, but I'm fine with that changing in a future PR if the need arises

@Racer159 Racer159 merged commit a51bbe7 into main May 21, 2024
7 checks passed
@Racer159 Racer159 deleted the migrate-exec-variables branch May 21, 2024 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Noxsios Noxsios Noxsios approved these changes

@AustinAbro321 AustinAbro321 AustinAbro321 approved these changes

@jeff-mccoy jeff-mccoy Awaiting requested review from jeff-mccoy jeff-mccoy is a code owner

@lucasrod16 lucasrod16 Awaiting requested review from lucasrod16

Assignees

@Racer159 Racer159

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Racer159 @AustinAbro321 @Noxsios @lucasrod16