fix: allow include loops while preventing task loops #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The previous task loop logic is a classic example of the https://en.wikipedia.org/wiki/Halting_problem |
zachariahmiller
approved these changes
Oct 17, 2024
zachariahmiller
requested changes
Oct 17, 2024
zachariahmiller
previously approved these changes
Oct 17, 2024
zachariahmiller
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Marking this as a fix to #122 since it will fix the issue in most cases and it allows loops since those can be valid constructs in some cases. Long term we still need to refactor this code.
Related Issue
Fixes #122
Type of change
Checklist before merging