Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: improve spinner when used with --no-progress #105

Merged
merged 2 commits into from
May 29, 2024

Conversation

Racer159
Copy link
Contributor

Description

This slightly improves the spinner to allow for interactive programs to run when --no-progress is provided.

Related Issue

Relates to #103

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

@Racer159 Racer159 changed the title chore: improve spinner with --no-progress chore: improve spinner with --no-progress May 29, 2024
@Racer159 Racer159 changed the title chore: improve spinner with --no-progress chore: improve spinner when used with --no-progress May 29, 2024
@marshall007
Copy link

Are there relevant tests I can run to reproduce the issue? Spinner has never printed cleanly for me, at least in the context of uds-cli so happy to try this out.

@marshall007
Copy link

via Slack:

The easiest way to test it is to run maru inside maru (basically build it and then call build/maru in a task) then run the parent command with and without --no-progress

This worked for me (I think) but should we add this to the e2e tests to clarify expected behavior?

marshall007
marshall007 previously approved these changes May 29, 2024
@Racer159 Racer159 merged commit 924c2b9 into main May 29, 2024
8 checks passed
@Racer159 Racer159 deleted the improve-interactive-spinner branch May 29, 2024 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants