chore: new 'types' module #963
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for leapfrogai-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
alekst23
force-pushed
the
774-choreapi-move-request-types-and-validation-into-routersrequests
branch
from
b8c2b4a to
ad14690
Compare
Migrate Request types for run.create methods to new types module
alekst23
force-pushed
the
774-choreapi-move-request-types-and-validation-into-routersrequests
branch
from
e5cf51b to
8bbdf1a
Compare
…830) * Enables Supabase realtime for the vector_store_file table * Adds new Python dependency to test supabase-realtime * Status is currently being set during indexing so listening to this table should provide status updates on the file indexing process.
Migrate Request types for run.create methods to new types module
justinthelaw
deleted the
774-choreapi-move-request-types-and-validation-into-routersrequests
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We need a better way to organize our type definitions. Currently we have the following issues:
src/leapfrogai_api/backend/types.py. Very long file with many types for different purposes defined together. Difficult to analyze and find code.Good format to follow is the OpenAI types module:
https://github.com/openai/openai-python/tree/main/src/openai/types
BREAKING CHANGES
All changes to type definitions should be applied to all relevant files as part of the PR.
CHANGES
leapfrogai_apiis created:types.src/leapfrogai_api/backend/typesto the newtypesmodulesrc/leapfrogai_api/types/constants.pyRelated Issue
Precursor to:
#948
Checklist before merging