-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
toml install / requirements version boost #1242
Conversation
@bgruening Do you mind having a look ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, a few comments inline :)
Thanks @WardDeb
.github/workflows/planemo.yml
Outdated
@@ -27,7 +40,7 @@ jobs: | |||
runs-on: ubuntu-latest | |||
strategy: | |||
matrix: | |||
python-version: ['3.7'] | |||
python-version: ['3.10'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we could test multiple versions if we like.
Historically we tested for the lower bound. But we could test for lower and upper-supported python versions.
3.8 and 3.11?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've included 3.7 & 3.11, though I'm not sure how relevant it is at this stage (planemo_combine_outputs): The tests have already ran at that time, right ?
Co-authored-by: Björn Grüning <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice. Thanks a lot @WardDeb
Welcome to deepTools GitHub repository! Please check the following regarding
your pull request :
This PR tries to update requirements / python setup to more recent versions (>=3.7).