-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated paper with example images #116
Conversation
@bnord Have you had a chance to look at this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should do the following
- update the images
2. higher resolution for the overview_diagram
3. remove the png's that don't have names
4. update the grid of images
5. add the physics plots - update the paper.md with the latest text from the overleaf
@bnord Addressed those issues. Only thing standing is that the compiled pdf from the make_pdf workflow does not have the citations, and the format of those citations is..odd. Is that something we should be concerned with, or is that more an issue with the action not being a perfect replication the joss submission workflow? I can't find anything wrong with either the workflow or the paper format so 🤷 |
Additional note - You can see the output paper in this workflow output (just scroll to the bottom of the page on any completed run and download 'paper.zip') |
Addressing issues #7 #10 #9
Pulled the paper from the overleaf - let me know if there are more updates that need to be made.