Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated paper with example images #116

Merged
merged 14 commits into from
Jan 30, 2024
Merged

Updated paper with example images #116

merged 14 commits into from
Jan 30, 2024

Conversation

voetberg
Copy link
Contributor

@voetberg voetberg commented Jul 5, 2023

Addressing issues #7 #10 #9

Pulled the paper from the overleaf - let me know if there are more updates that need to be made.

@voetberg voetberg requested a review from bnord July 5, 2023 19:08
@voetberg
Copy link
Contributor Author

@bnord Have you had a chance to look at this?

Copy link
Collaborator

@bnord bnord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should do the following

  1. update the images
    2. higher resolution for the overview_diagram
    3. remove the png's that don't have names
    4. update the grid of images
    5. add the physics plots
  2. update the paper.md with the latest text from the overleaf

@voetberg
Copy link
Contributor Author

@bnord Addressed those issues.

Only thing standing is that the compiled pdf from the make_pdf workflow does not have the citations, and the format of those citations is..odd. Is that something we should be concerned with, or is that more an issue with the action not being a perfect replication the joss submission workflow? I can't find anything wrong with either the workflow or the paper format so 🤷

@voetberg voetberg requested a review from bnord October 24, 2023 14:10
@voetberg
Copy link
Contributor Author

Additional note - You can see the output paper in this workflow output (just scroll to the bottom of the page on any completed run and download 'paper.zip')

@bnord bnord merged commit 36888c6 into development Jan 30, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants