Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor lmi and trt dockerfiles to install python requirements from … #2542

Closed

Conversation

siddvenk
Copy link
Contributor

…requirements file

Description

This PR changes our dockerfile to install python dependencies via a requirements file. This is easier to parse than the full set of versions and dependencies in our docker file.

Additionally, it gives us the ability to:

  • specify version ranges, or less strict version requirements per dependency
  • ensure we install compatible versions of dependencies by relying on the pip dependency resolver

Few more change I want to make before moving out of the draft stage, but this is more or less what it will look like.
I've tested the integ tests locally to verify the newly built containers are functioning as expected.

@siddvenk siddvenk force-pushed the refactor-dockerfiles branch 5 times, most recently from 6537c82 to efe7803 Compare November 12, 2024 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant