Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[lcnc] support dbrx model #1695

Merged
merged 1 commit into from
Mar 29, 2024
Merged

[lcnc] support dbrx model #1695

merged 1 commit into from
Mar 29, 2024

Conversation

siddvenk
Copy link
Contributor

@siddvenk siddvenk commented Mar 28, 2024

Description

lcnc support for dbrx, lcnc integ tests

@siddvenk siddvenk requested review from zachgk, frankfliu and a team as code owners March 28, 2024 23:13
Copy link
Contributor

@lanking520 lanking520 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, but we may need extra longer time to get model download. Didn't do benchmark on that yet, but would expect long

run: |
rm -rf models
echo -en "HF_MODEL_ID=s3://djl-llm/dbrx-instruct/" > docker_env
./launch_container.sh deepjavalibrary/djl-serving:$DJLSERVING_DOCKER_TAG $PWD/models ${{ matrix.container }} \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we also need to set OPTION_GPU_MEMORY_UTILIZATION=0.95 along with it

@siddvenk siddvenk merged commit 1228553 into deepjavalibrary:master Mar 29, 2024
8 checks passed
@siddvenk siddvenk deleted the dbrx branch March 29, 2024 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants