[lmi] log warnings for unused generation parameters across all rollin… #1686
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…g batch backends instead of throwing errors
Description
This PR standardizes the behavior across all rolling batch backends to log warnings for unused generation parameters. Before, some backends would throw errors, and some would succeed.
I have also logged the unused parameters, and the supported set of parameters. The supported set of parameters does include some stuff that the user should not set, so it's not perfect. I'm ok to remove that portion for now and just log the unused params to the warning.
Testing Samples
Using the following request:
vllm (would fail before)
lmi-dist (would fail before)
hf-accelerate w/scheduler
deepspeed
tnx
optimum: