-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Daily and Unit Tests #443
Implement Daily and Unit Tests #443
Conversation
8f8e7fb
to
a480664
Compare
Important Review skippedMore than 25% of the files skipped due to max files limit. The review is being skipped to prevent a low-quality review. 32 files out of 89 files are above the max files limit of 50. Please upgrade to Pro plan to get higher limits. You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
4b4b72e
to
5012b32
Compare
5012b32
to
6f47b5c
Compare
6f47b5c
to
a0ebf9d
Compare
Proposed changes
Addresses Issues: #392 #391
The Daily and Unit Tests will verify:
Daily Tests
The daily tests invoke a series of checks against the actual/real API endpoint and save the results in the
tests/response_data
folder. This response data is updated nightly to reflect the latest response from the server. Running the daily tests does require aDEEPGRAM_API_KEY
set in your environment variables.To run the Daily Tests:
Unit Tests
The unit tests invoke a series of checks against mock endpoints using the responses saved in
tests/response_data
from the daily tests. These tests are meant to simulate running against the endpoint without actually reaching out to the endpoint; running the unit tests does require aDEEPGRAM_API_KEY
set in your environment variables because the client SDK code checks this, but you will not actually reach out to the server.To Run All The Tests (Daily + Unit)
make test
Additional changes to support this PR:
class BaseResponse
to which all response objects inherit. This removes duplication and also introduced a neweval
function to support querying the JSON string contained within the object.*kwargs
to remaining functions that were missing the parameter. This was needed to support passing in the mockhttpx
responses for themake unit-test
portion of code.examples/text-to-speech/rest
examples to renameSPEAK_OPTIONS
toSPEAK_TEXT
as they were incorrectly named. The variable is providing text to convert not the API options/parameters.Types of changes
What types of changes does your code introduce to the community Python SDK?
Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
NA