-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RestructureSpeak
to Resolve Naming Convention, Update Listen
to Match
#426
RestructureSpeak
to Resolve Naming Convention, Update Listen
to Match
#426
Conversation
Warning Rate limit exceeded@dvonthenen has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 1 minutes and 40 seconds before requesting another review. How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. WalkthroughThe changes primarily involve renaming classes and adjusting import paths in Deepgram's client SDK for both REST and WebSocket communication, especially for text-to-speech functionalities. These changes also include adding new response type classes for WebSocket communication, and updating sample scripts for both REST and WebSocket usage. Additionally, there are updates to dependencies in configuration files to ensure compatibility and use of the latest versions. Changes
Tip Early access features: enabledWe are currently testing the following features in early access:
Note:
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Proposed changes
This performs a similar restructure for
speak
and also forlisten
to make the dot notation accessors behave in similar ways. This change provides backward compatibility with deprecation warnings for removal in the next major version.Although, the PR looks large (was trying to best
git mv
things to make it look like I was just organizing things), it did work in some cases and in many others, it did not.deepgram.listen
ChangesTo demonstrate the approach on this PR, the following changes were made to the
listen
.The way it is currently:
The files were moved into a
deepgram.listen.<rest | websocket>.v1
folder, anddeepgram.listen.<prerecorded | live>.v1
creates backward-compatible links to artifacts in these new folders.For listen, so to access the classes in the dot notation, it looks like this now:
deepgram.listen.prerecorded.v("1")
(old) ->deepgram.listen.rest.v("1")
(new)deepgram.listen.live.v("1")
(old) ->deepgram.listen.websocket.v("1")
(new)deepgram.speak
ChangesSpeak is slightly different since we are implementing TTS WS in this release, we are making the dot notation for access to
deepgram.speak.websocket.v("1")
.For REST, we are providing backward compatibility just like
listen
, so the accessors look like this now.deepgram.speak.v("1")
(old) ->deepgram.speak.rest.v("1")
(new)When attempting to use prerecorded, for example, it will still function normally, but you will be greeted with the following warning:
TODO:
Types of changes
What types of changes does your code introduce to the community Python SDK?
Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
NA
Summary by CodeRabbit
New Features
Refactor
Examples
Dependencies
requirements.txt
.deprecation
package inpyproject.toml
andsetup.py
.