Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change OnPrem -> SelfHosted, But Preserve Backward Compatibility #412

Merged
merged 1 commit into from
Jun 12, 2024

Conversation

davidvonthenen
Copy link
Contributor

Proposed changes

Addresses: #405

This attempts to preserve backward compatibility with the user's code. The default will use the new "SelfHosted" names for classes.

Types of changes

What types of changes does your code introduce to the community Python SDK?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update or tests (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have lint'ed all of my code using repo standards
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

NA

@davidvonthenen davidvonthenen changed the title Change OnPrem -> SelfHosted, But Preserve Backward Compatibility Change OnPrem -> SelfHosted, But Preserve Backward Compatibility Jun 11, 2024
@davidvonthenen davidvonthenen merged commit c3b8dc5 into deepgram:main Jun 12, 2024
3 checks passed
@davidvonthenen davidvonthenen deleted the self-hosted branch June 12, 2024 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants