Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some delay before servers are sync #1970

Merged
merged 4 commits into from
Jun 30, 2024

Conversation

arnauds5
Copy link
Collaborator

When a federation challenge is successfully handled in go, a federation result is broadcast and the organizers frontends will try to subscribe/catchup to the other lao channel, but if the server isn't synced yet, then they will failed.
A goroutine is started to avoid blocking the messages handlers (single thread), and will wait until the remote channel is available locally.

@arnauds5 arnauds5 requested a review from a team as a code owner June 30, 2024 12:50
Copy link

Pull reviewers stats

Stats of the last 30 days for popstellar:

User Total reviews Time to review Total comments
K1li4nL
🥇
24
▀▀▀▀
7h 1m
12
▀▀
matteosz
🥈
12
▀▀
2d 6m
22
▀▀▀
arnauds5
🥉
7
4h 29m
4
emonnin-epfl
7
8h 20m
8
sgueissa
4
1h 25m
7
onsriahi14
3
1d 10h 51m
4
quadcopterman
3
10d 7h 3m
▀▀▀▀
1
1florentin
2
10d 5h 50m
▀▀▀▀
0
MariemBaccari
2
22h 39m
6
Kaz-ookid
2
2d 4h 12m
9
simone-kalbermatter
1
9h 17m
0
⚡️ Pull request stats

sgueissa
sgueissa previously approved these changes Jun 30, 2024
Copy link
Collaborator

@sgueissa sgueissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

sonarcloud bot commented Jun 30, 2024

@sgueissa sgueissa removed their assignment Jun 30, 2024
Copy link

sonarcloud bot commented Jun 30, 2024

Copy link

sonarcloud bot commented Jun 30, 2024

Quality Gate Failed Quality Gate failed for 'PoP - Be1-Go'

Failed conditions
37.5% Coverage on New Code (required ≥ 65%)

See analysis details on SonarCloud

Copy link

sonarcloud bot commented Jun 30, 2024

@arnauds5 arnauds5 added this pull request to the merge queue Jun 30, 2024
Merged via the queue into master with commit 4901524 Jun 30, 2024
16 of 17 checks passed
@arnauds5 arnauds5 deleted the work-be1-arnauds5-delay-federationresult-after-sync branch June 30, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants