wallet: Make validateHeaderChainDifficulties fulfill contract #2294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrick
approved these changes
Nov 9, 2023
|
please rebase |
This makes the branch that handles the error for checkDifficultyPositional() return the invalid chain in validateHeaderChainDifficulties. Previously this branch failed to fulfill the contract of the function.
matheusd
force-pushed
the
check-diff-pos-return-subchain
branch
from
1f424cc to
de27db4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the branch that handles the error for
checkDifficultyPositional() return the invalid chain in validateHeaderChainDifficulties.
Previously this branch failed to fulfill the contract of the function.