-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Linx Impulse] - Fix: add SKU props on response #909
base: main
Are you sure you want to change the base?
[Linx Impulse] - Fix: add SKU props on response #909
Conversation
Tagging OptionsShould a new tag be published when this PR is merged?
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be great remove the lint changes
return toPropertyValue({ name: key, value: sanitizeValue(value) }); | ||
}), | ||
...Object.entries(variant.specs ?? {}).flatMap(([key, value]) => { | ||
// console.log('LOG:','valueeee:', key, value); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove console.log
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, use default lint on this PR.
return toPropertyValue({ name: key, value: sanitizeValue(value) }); | ||
}), | ||
...Object.entries(variant.specs ?? {}).flatMap(([key, value]) => { | ||
// console.log('LOG:','valueeee:', key, value); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
// console.log('LOG:','valueeee:', key, value); |
This PR add SKU props on additionalProperty of productList.