-
Notifications
You must be signed in to change notification settings - Fork 275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Deserialize using a generic approach. #121
Conversation
There is currently a known issue where the |
One more question, currently |
Can you be more specific what the issue was? I personally don't use the Marshal/Unmarshal too much but to my knowledge the tests were all previously passing. |
I'd rather ideally rather not export them because the |
Is this what your PR fixes? Or is this a separate issue. I would be more inclined to expedite this work if we can get a issue/PR created per issue that you are having. |
The current test for Marshal/Unmarshal only includes tests for the string type. When the element type of the set is int64, you can refer to this code snippet. In reality, it cannot be deserialized successfully as expected. This pull request fixes the issue. With this correction, deserialization of int64 elements works correctly. |
Deserialize using generics. The previous deserialization method had issues in generic scenarios.