Merge branch 'main' of https://github.com/cosmos/interchain-security …

…into nhan/add_QueryAllPairsValConAddrByConsumerChainID

.changelog/epilogue.md

@@ -81,7 +81,7 @@ Some PRs from v2.0.0 may reappear from other releases below. This is due to the
 
 * (feat!) Add DistributionTransmissionChannel to ConsumerAdditionProposal [#965](https://github.com/cosmos/interchain-security/pull/965)
 * (feat/fix) limit vsc matured packets handled per endblocker [#1004](https://github.com/cosmos/interchain-security/pull/1004)
-* (fix) cosumer key prefix order to avoid complex migrations [#963](https://github.com/cosmos/interchain-security/pull/963) and [#991](https://github.com/cosmos/interchain-security/pull/991). The latter PR is the proper fix.
+* (fix) consumer key prefix order to avoid complex migrations [#963](https://github.com/cosmos/interchain-security/pull/963) and [#991](https://github.com/cosmos/interchain-security/pull/991). The latter PR is the proper fix.
 * (feat) v1->v2 migrations to accommodate a bugfix having to do with store keys, introduce new params, and deal with consumer genesis state schema changes [#975](https://github.com/cosmos/interchain-security/pull/975) and [#997](https://github.com/cosmos/interchain-security/pull/997)
 * (deps) Bump github.com/cosmos/ibc-go/v4 from 4.4.0 to 4.4.2 [#982](https://github.com/cosmos/interchain-security/pull/982)
 * (fix) partially revert key assignment type safety PR [#980](https://github.com/cosmos/interchain-security/pull/980)

.github/.codespellignore

@@ -0,0 +1,3 @@
+clienta
+connectiona
+sover

.github/PULL_REQUEST_TEMPLATE.md

@@ -1,5 +1,5 @@
-Please go the the `Preview` tab and select the appropriate sub-template:
+Please go to the `Preview` tab and select the appropriate sub-template:
 
 * [Production code](?expand=1&template=production.md) - for types `fix`, `feat`, and `refactor`.
 * [Docs](?expand=1&template=docs.md) - for documentation changes.
-* [Others](?expand=1&template=others.md) - for changes that do not affect production code.
+* [Others](?expand=1&template=others.md) - for changes that do not affect production code.

.github/PULL_REQUEST_TEMPLATE/production.md

@@ -19,7 +19,7 @@ please add links to any relevant follow up issues.*
 I have...
 
 * [ ] Included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
-* [ ] Added `!` to the type prefix if state-machine breaking change (i.e., requires coordinated upgrade)
+* [ ] Added `!` to the type prefix if the change is [state-machine breaking](https://github.com/cosmos/interchain-security/blob/main/RELEASES.md#breaking-changes)
 * [ ] Confirmed this PR does not introduce changes requiring state migrations, OR migration code has been added to consumer and/or provider modules
 * [ ] Targeted the correct branch (see [PR Targeting](https://github.com/cosmos/interchain-security/blob/main/CONTRIBUTING.md#pr-targeting))
 * [ ] Provided a link to the relevant issue or specification
@@ -40,7 +40,7 @@ your handle next to the items reviewed if you only reviewed selected items.*
 I have...
 
 * [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
-* [ ] confirmed `!` in the type prefix if API or client breaking change
+* [ ] confirmed `!` the type prefix if the change is state-machine breaking
 * [ ] confirmed this PR does not introduce changes requiring state migrations, OR confirmed migration code has been added to consumer and/or provider modules
 * [ ] confirmed all author checklist items have been addressed
 * [ ] reviewed state machine logic

.github/workflows/codeql-analysis.yml

@@ -35,13 +35,13 @@ jobs:
     steps:
       - name: Checkout repository
         uses: actions/checkout@v4
-      - uses: actions/setup-go@v4
+      - uses: actions/setup-go@v5
         with:
           go-version: "1.20"
           check-latest: true
       # Initializes the CodeQL tools for scanning.
       - name: Initialize CodeQL
-        uses: github/codeql-action/init@v2
+        uses: github/codeql-action/init@v3
         # Override language selection by uncommenting this and choosing your languages
         with:
           languages: go
@@ -55,7 +55,7 @@ jobs:
       # Autobuild attempts to build any compiled languages (C/C++, C#, or Java).
       # If this step fails, then you should remove it and run the build manually (see below).
       - name: Autobuild
-        uses: github/codeql-action/autobuild@v2
+        uses: github/codeql-action/autobuild@v3
 
       # ℹ️ Command-line programs to run using the OS shell.
       # 📚 See https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idstepsrun
@@ -69,4 +69,4 @@ jobs:
       #     make release
 
       - name: Perform CodeQL Analysis
-        uses: github/codeql-action/analyze@v2
+        uses: github/codeql-action/analyze@v3

.github/workflows/codespell.yml

@@ -0,0 +1,28 @@
+name: Fix typos nightly
+
+on:
+  schedule:
+    - cron: "0 12 * * *"
+
+jobs:
+  build:
+    runs-on: ubuntu-latest
+
+    steps:
+      - uses: actions/checkout@v4
+      - name: Run codespell
+        continue-on-error: true
+        run: |
+          sudo apt-get install codespell -y
+          codespell -w --skip="*.pb.go,*.pb.gw.go,*.json,*.git,*.js" --ignore-words=.github/.codespellignore
+      - uses: peter-evans/create-pull-request@v5
+        with:
+          token: ${{ secrets.PRBOT_PAT }}
+          commit-message: "chore: spelling errors fixes"
+          title: "chore: fix spelling errors"
+          branch: "bot/fix-typos"
+          delete-branch: true
+          body: |
+            This PR fixes typos in the codebase.
+            Please review it, and merge if everything is fine.
+            If there are proto changes, run `make proto-gen` and commit the changes.

.github/workflows/deploy-docs.yml

@@ -1,5 +1,5 @@
 name: Deploy docs
-# This job builds and deploys documenation to github pages.
+# This job builds and deploys documentation to github pages.
 # It runs on every push to main with a change in the docs folder.
 on:
   workflow_dispatch:

.github/workflows/golangci-lint.yml

@@ -14,7 +14,7 @@ jobs:
     name: golangci-lint
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/setup-go@v4
+      - uses: actions/setup-go@v5
         with:
           go-version: '1.20'
       - uses: technote-space/[email protected]

.github/workflows/manual-e2e.yml

@@ -9,14 +9,14 @@ jobs:
     runs-on: ubuntu-latest
     timeout-minutes: 20
     steps:
-      - uses: actions/setup-go@v4
+      - uses: actions/setup-go@v5
         with:
           go-version: "1.20"
       - uses: actions/checkout@v4
       - name: Checkout LFS objects
         run: git lfs checkout
       - name: Setup Go
-        uses: actions/setup-go@v4
+        uses: actions/setup-go@v5
         with:
           go-version: "1.20" # The Go version to download (if necessary) and use.
       - name: E2E happy-path test
@@ -25,14 +25,14 @@ jobs:
     runs-on: ubuntu-latest
     timeout-minutes: 20
     steps:
-      - uses: actions/setup-go@v4
+      - uses: actions/setup-go@v5
         with:
           go-version: "1.20"
       - uses: actions/checkout@v4
       - name: Checkout LFS objects
         run: git lfs checkout
       - name: Setup Go
-        uses: actions/setup-go@v4
+        uses: actions/setup-go@v5
         with:
           go-version: "1.20" # The Go version to download (if necessary) and use.
       - name: E2E changeover test
@@ -41,14 +41,14 @@ jobs:
       runs-on: ubuntu-latest
       timeout-minutes: 20
       steps:
-        - uses: actions/setup-go@v4
+        - uses: actions/setup-go@v5
           with:
             go-version: "1.20"
         - uses: actions/checkout@v4
         - name: Checkout LFS objects
           run: git lfs checkout
         - name: Setup Go
-          uses: actions/setup-go@v4
+          uses: actions/setup-go@v5
           with:
             go-version: "1.20" # The Go version to download (if necessary) and use.
         - name: E2E democracy-reward tests
@@ -57,14 +57,14 @@ jobs:
       runs-on: ubuntu-latest
       timeout-minutes: 20
       steps:
-        - uses: actions/setup-go@v4
+        - uses: actions/setup-go@v5
           with:
             go-version: "1.20"
         - uses: actions/checkout@v4
         - name: Checkout LFS objects
           run: git lfs checkout
         - name: Setup Go
-          uses: actions/setup-go@v4
+          uses: actions/setup-go@v5
           with:
             go-version: "1.20" # The Go version to download (if necessary) and use.
         - name: E2E democracy tests
@@ -73,14 +73,14 @@ jobs:
       runs-on: ubuntu-latest
       timeout-minutes: 20
       steps:
-        - uses: actions/setup-go@v4
+        - uses: actions/setup-go@v5
           with:
             go-version: "1.20"
         - uses: actions/checkout@v4
         - name: Checkout LFS objects
           run: git lfs checkout
         - name: Setup Go
-          uses: actions/setup-go@v4
+          uses: actions/setup-go@v5
           with:
             go-version: "1.20" # The Go version to download (if necessary) and use.
         - name: E2E slash-throttle tests
@@ -89,14 +89,14 @@ jobs:
       runs-on: ubuntu-latest
       timeout-minutes: 40
       steps:
-        - uses: actions/setup-go@v4
+        - uses: actions/setup-go@v5
           with:
             go-version: "1.20"
         - uses: actions/checkout@v4
         - name: Checkout LFS objects
           run: git lfs checkout
         - name: Setup Go
-          uses: actions/setup-go@v4
+          uses: actions/setup-go@v5
           with:
             go-version: "1.20" # The Go version to download (if necessary) and use.
         - name: E2E multi-consumer tests

.github/workflows/md-link-checker.yml

@@ -4,6 +4,7 @@ on:
     paths:
       - "*.md"
       - "docs/docs/**.md"
+      - "tests/e2e/README.md"
 jobs:
   repo-root:
     runs-on: ubuntu-latest
@@ -21,7 +22,10 @@ jobs:
     steps:
       # Check out the latest version of the code
       - uses: actions/checkout@v4
-      # Checks the status of hyperlinks in *.md files in the docs/docs folder
+      # Checks the status of hyperlinks in *.md files in the docs/docs folder,
+      # as well as various explicitly listed files throughout the repo.
+      # We don't use this to check the repo root, since there we want to use max-depth=1.
       - uses: gaurav-nelson/[email protected]
         with:
           folder-path: 'docs/docs'
+          file-path: 'tests/e2e/README.md'

.github/workflows/nightly-e2e.yml

@@ -22,14 +22,14 @@ jobs:
     runs-on: ubuntu-latest
     timeout-minutes: 20
     steps:
-      - uses: actions/setup-go@v4
+      - uses: actions/setup-go@v5
         with:
           go-version: "1.20"
       - uses: actions/checkout@v4
       - name: Checkout LFS objects
         run: git lfs checkout
       - name: Setup Go
-        uses: actions/setup-go@v4
+        uses: actions/setup-go@v5
         with:
           go-version: "1.20" # The Go version to download (if necessary) and use.
       - name: E2E happy-path test
@@ -38,14 +38,14 @@ jobs:
     runs-on: ubuntu-latest
     timeout-minutes: 20
     steps:
-      - uses: actions/setup-go@v4
+      - uses: actions/setup-go@v5
         with:
           go-version: "1.20"
       - uses: actions/checkout@v4
       - name: Checkout LFS objects
         run: git lfs checkout
       - name: Setup Go
-        uses: actions/setup-go@v4
+        uses: actions/setup-go@v5
         with:
           go-version: "1.20" # The Go version to download (if necessary) and use.
       - name: E2E changeover test
@@ -54,14 +54,14 @@ jobs:
     runs-on: ubuntu-latest
     timeout-minutes: 20
     steps:
-      - uses: actions/setup-go@v4
+      - uses: actions/setup-go@v5
         with:
           go-version: "1.20"
       - uses: actions/checkout@v4
       - name: Checkout LFS objects
         run: git lfs checkout
       - name: Setup Go
-        uses: actions/setup-go@v4
+        uses: actions/setup-go@v5
         with:
           go-version: "1.20" # The Go version to download (if necessary) and use.
       - name: E2E democracy-reward tests
@@ -70,14 +70,14 @@ jobs:
     runs-on: ubuntu-latest
     timeout-minutes: 20
     steps:
-      - uses: actions/setup-go@v4
+      - uses: actions/setup-go@v5
         with:
           go-version: "1.20"
       - uses: actions/checkout@v4
       - name: Checkout LFS objects
         run: git lfs checkout
       - name: Setup Go
-        uses: actions/setup-go@v4
+        uses: actions/setup-go@v5
         with:
           go-version: "1.20" # The Go version to download (if necessary) and use.
       - name: E2E democracy tests
@@ -86,14 +86,14 @@ jobs:
     runs-on: ubuntu-latest
     timeout-minutes: 20
     steps:
-      - uses: actions/setup-go@v4
+      - uses: actions/setup-go@v5
         with:
           go-version: "1.20"
       - uses: actions/checkout@v4
       - name: Checkout LFS objects
         run: git lfs checkout
       - name: Setup Go
-        uses: actions/setup-go@v4
+        uses: actions/setup-go@v5
         with:
           go-version: "1.20" # The Go version to download (if necessary) and use.
       - name: E2E slash-throttle tests
@@ -102,14 +102,14 @@ jobs:
     runs-on: ubuntu-latest
     timeout-minutes: 40
     steps:
-      - uses: actions/setup-go@v4
+      - uses: actions/setup-go@v5
         with:
           go-version: "1.20"
       - uses: actions/checkout@v4
       - name: Checkout LFS objects
         run: git lfs checkout
       - name: Setup Go
-        uses: actions/setup-go@v4
+        uses: actions/setup-go@v5
         with:
           go-version: "1.20" # The Go version to download (if necessary) and use.
       - name: E2E multi-consumer tests