Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(did-comm): remove isomorphic-webcrypto dependency #1401

Merged
merged 1 commit into from
Jul 11, 2024

Conversation

mirceanis
Copy link
Member

What issue is this PR fixing

fixes #1381
fixes #1387

What is being changed

Removed isomorphic-webcrypto dependency in favor of @noble/ciphers + @noble/hashes.
This also allowed us to remove several other @stablelib/* dependencies from the @veramo/did-comm package.

I also updated the encryption tests to include the test-vectors that were previously unused.

Quality

Check all that apply:

  • I want these changes to be integrated
  • I successfully ran pnpm i, pnpm build, pnpm test, pnpm test:browser locally.
  • I allow my PR to be updated by the reviewers (to speed up the review process).
  • I added unit tests.
  • I added integration tests.

@mirceanis mirceanis added the pinned don't close this just for being stale label Jul 11, 2024
@mirceanis mirceanis force-pushed the 1381-remove-isomorphic-webcrypto branch from a037747 to e2f8159 Compare July 11, 2024 13:55
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 96.42857% with 1 line in your changes missing coverage. Please review.

Project coverage is 89.72%. Comparing base (018e189) to head (e2f8159).

Files Patch % Lines
...kages/did-comm/src/encryption/a256cbc-hs512-dir.ts 92.30% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             next    #1401      +/-   ##
==========================================
- Coverage   89.73%   89.72%   -0.02%     
==========================================
  Files         177      177              
  Lines       26846    26810      -36     
  Branches     2220     2220              
==========================================
- Hits        24090    24054      -36     
  Misses       2756     2756              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file had the last dependency on isomorphic-webcrypto

Copy link
Contributor

@nickreynolds nickreynolds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@mirceanis mirceanis merged commit 85cc1ce into next Jul 11, 2024
9 checks passed
@mirceanis mirceanis deleted the 1381-remove-isomorphic-webcrypto branch July 11, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pinned don't close this just for being stale
Projects
None yet
3 participants