Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove isomorphic-webcrypto dependency from veramo/didcom #1387

Closed
vadimchilinciuc opened this issue May 30, 2024 · 3 comments · Fixed by #1401
Closed

Remove isomorphic-webcrypto dependency from veramo/didcom #1387

vadimchilinciuc opened this issue May 30, 2024 · 3 comments · Fixed by #1401
Assignees
Labels
bug Something isn't working work-in-progress

Comments

@vadimchilinciuc
Copy link

Bug severity
4 being critical

**When build with expo i get an error related to veramo/didcom specificaly to isomorphic-webcrypto dependency ,that have @unimodule/core dependency **

Error:
Build file '...../node_modules/@unimodules/core/android/build.gradle' line: 3

  • What went wrong:
    A problem occurred evaluating project ':unimodules-core'.

Plugin with id 'maven' not found.

i ask if its possible to find a way to change the package cause its old and he need to Migrate to Expo-Modules for Expo SDK 43 and newer, and not use unimodules-core but expo-modules instead.
Versions (please complete the following information):

  • Veramo: 6
  • Browser [ chrome]
  • Node Version 22.12.2
@vadimchilinciuc vadimchilinciuc added the bug Something isn't working label May 30, 2024
@vadimchilinciuc vadimchilinciuc changed the title Old isomorphic-webcrypto dependency need an update with expo 43+ sdk Remove isomorphic-webcrypto dependency from veramo/didcom May 30, 2024
@mirceanis
Copy link
Member

seems related to #1381

@mirceanis mirceanis self-assigned this Jul 11, 2024
mirceanis added a commit that referenced this issue Jul 11, 2024
mirceanis added a commit that referenced this issue Jul 11, 2024
@vadimchilinciuc
Copy link
Author

vadimchilinciuc commented Oct 24, 2024

Thanks @mirceanis ! <3
Can we know when they will bee release ? Cause for know i can directly install them through : npm install veramo , its install the 6.0 version

@mirceanis
Copy link
Member

Can we know when they will bee release ?

@vadimchilinciuc you can already test this installing your veramo packages from the @next dist-tag; for example npm install @veramo/did-comm@next. Remember that veramo packages are not meant to be used with mixed versions. They might work but there is no guarantee. Try to keep all of them at the same version.

The next release will be a breaking change release (v7.0.0), as the credential plugins have changed API to allow easier extension without needing to modify the veramo core. Installing from the @next dist-tag gives you a preview of the upcoming changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working work-in-progress
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants