bitcoin core v23 creates descriptor wallets by default, passing false…

… parameter for descriptors
decentralized-identity · Jun 18, 2022 · 8322d03 · 8322d03
1 parent 006e03e
commit 8322d03
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 4 deletions.
diff --git a/lib/bitcoin/BitcoinClient.ts b/lib/bitcoin/BitcoinClient.ts
@@ -236,9 +236,14 @@ export default class BitcoinClient {
   }
 
   private async createWallet () {
+    // Bitcoin Core 23.0 creates discriptor wallets by default, must set to false until further updates can be made to this repo.
+    // https://github.com/bitcoin/bitcoin/blob/master/doc/release-notes/release-notes-23.0.md#wallet
     const request = {
       method: 'createwallet',
-      params: [this.walletNameToUse] // the wallet name
+      params: {
+        wallet_name: this.walletNameToUse,
+        descriptors: false
+      }
     };
 
     // Intentionally not throwing because bitcoin returns 500 when a wallet is already created

diff --git a/tests/bitcoin/BitcoinClient.spec.ts b/tests/bitcoin/BitcoinClient.spec.ts
@@ -338,7 +338,10 @@ describe('BitcoinClient', async () => {
       await bitcoinClient['createWallet']();
       expect(rpcSpy).toHaveBeenCalledWith({
         method: 'createwallet',
-        params: ['sidetreeDefaultWallet']
+        params: {
+          wallet_name: 'sidetreeDefaultWallet',
+          descriptors: false
+        }
       }, true, false);
       expect(loggerSpy).toHaveBeenCalledWith(`Wallet created with name "sidetreeDefaultWallet".`);
     });
@@ -351,7 +354,10 @@ describe('BitcoinClient', async () => {
       } catch {
         expect(rpcSpy).toHaveBeenCalledWith({
           method: 'createwallet',
-          params: ['sidetreeDefaultWallet']
+          params: {
+            wallet_name: 'sidetreeDefaultWallet',
+            descriptors: false
+          }
         }, true, false);
       }
     });
@@ -362,7 +368,10 @@ describe('BitcoinClient', async () => {
       await bitcoinClient['createWallet']();
       expect(rpcSpy).toHaveBeenCalledWith({
         method: 'createwallet',
-        params: ['sidetreeDefaultWallet']
+        params: {
+          wallet_name: 'sidetreeDefaultWallet',
+          descriptors: false
+        }
       }, true, false);
       expect(loggerSpy).toHaveBeenCalledWith(`Wallet with name sidetreeDefaultWallet already exists.`);
     });