Fix #217 and other misc updates #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
decentralgabe
requested review from
csuwildcat,
frankhinek and
mistermoe
as code owners
decentralgabe
commented
May 9, 2024
| fairness in the retention and republishing of record sets by [[ref:Gateways]]. This mechanism, referred to as a | ||
| [[ref:Retention Proof]], requires clients to generate a proof value for write requests. This process guarantees that | ||
| the amount of work done by a client is proportional to the duration of data retention and republishing a [[ref:Gateway]] | ||
| fairness in the retention and [[ref:republishing]] of record sets by [[ref:Gateways]]. This mechanism, referred to as a |
There was a problem hiding this comment.
note much of this language will change in a follow-up PR for #74
There was a problem hiding this comment.
you may want to include the reasoning being to defend against spam, and specifically write (or create/update) spam, idk just an idea
There was a problem hiding this comment.
this paragraph has a link to the section (#rate-limiting) which does this
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #218 +/- ##
=======================================
Coverage 51.62% 51.62%
=======================================
Files 32 32
Lines 2774 2774
=======================================
Hits 1432 1432
Misses 1199 1199
Partials 143 143 ☔ View full report in Codecov by Sentry. |
KendallWeihe
reviewed
May 9, 2024
| @@ -19,6 +19,7 @@ The DID DHT Method Specification 1.0 | |||
| ~ [Moe Jangda](https://github.com/mistermoe) | |||
| ~ [Frank Hinek](https://github.com/frankhinek) | |||
| ~ [Henry Tsai](https://github.com/thehenrytsai) | |||
| ~ [Kendall Weihe](https://github.com/KendallWeihe) | |||
KendallWeihe
reviewed
May 9, 2024
KendallWeihe
approved these changes
May 10, 2024
Co-authored-by: Kendall Weihe <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #217
thank you @KendallWeihe