fix: UserMenu mobile and notifications style #207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
braianj
changed the title
Deploying ui2 with
|
| Latest commit: |
2db68dd
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://6d56d168.ui2-423.pages.dev |
| Branch Preview URL: | https://style-notifications.ui2-423.pages.dev |
kevinszuchet
reviewed
Dec 9, 2024
| @@ -56,7 +63,7 @@ const NotificationFeedTabsListContainer = styled("div")(( | |||
| } | |||
| } | |||
|
|
|||
| return defaultStyles | |||
| return { ...defaultStyles, width: "90vw", height: "70vh" } | |||
There was a problem hiding this comment.
Why not setting the width and height already in the defaultStyles?
kevinszuchet
reviewed
Dec 9, 2024
Comment on lines
110
to
115
| <Modal open={isMobile && isOpen} onClose={onClose}> | ||
| <NotificationFeedModal | ||
| open={isMobile && isOpen} | ||
| onClose={onClose} | ||
| title={i18nTabs[locale].feed.title} | ||
| > |
There was a problem hiding this comment.
I know it comes from before. Out of curiosity, why will the feed modal open if it is already open or on mobile?
kevinszuchet
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.