Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add generate:storybooks again to the cloudflare build #206

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

braianj
Copy link
Collaborator

@braianj braianj commented Nov 25, 2024

No description provided.

@braianj braianj changed the title feat: add generate:storybooks again to the cloudflare biuld feat: add generate:storybooks again to the cloudflare build Nov 25, 2024
Copy link

cloudflare-workers-and-pages bot commented Nov 25, 2024

Deploying ui2 with  Cloudflare Pages  Cloudflare Pages

Latest commit: 5b7e268
Status: ✅  Deploy successful!
Preview URL: https://3098d14c.ui2-423.pages.dev
Branch Preview URL: https://feat-re-add-mui-build-to-sto.ui2-423.pages.dev

View logs

@braianj braianj self-assigned this Nov 25, 2024
@braianj braianj added the enhancement New feature or request label Nov 25, 2024
import {
componentTemplate,
storiesJustArgsTemplate,
storiesTemplate,
} from "./templates"
} from "./templates.ts"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it required the .ts?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes it's because we are executing node --loader ts-node/esm ./bin/storybookGenerator.ts

@LautaroPetaccio
Copy link
Contributor

I gave it a check and some of the components are not visible in the Vercel preview:
Screenshot 2024-11-28 at 09 16 06
Screenshot 2024-11-28 at 09 15 59

Would you mind giving it a check?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Review
Development

Successfully merging this pull request may close these issues.

3 participants