Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update RangeField component #815

Merged
merged 5 commits into from
Nov 1, 2023

Conversation

cyaiox
Copy link
Contributor

@cyaiox cyaiox commented Oct 30, 2023

This PR updates the RangeField component, adding the following states:

  • Disabled
  • Focus
  • Error

image

image

image

Closes decentraland/sdk#977

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Oct 30, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 84d9641
Status: ✅  Deploy successful!
Preview URL: https://01be9687.js-sdk-toolchain.pages.dev
Branch Preview URL: https://feat-update-range-input.js-sdk-toolchain.pages.dev

View logs

@github-actions
Copy link
Contributor

github-actions bot commented Oct 30, 2023

Test this pull request

  • The @dcl/sdk package can be tested in scenes by running

    npm install "https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/feat/update-range-input/dcl-sdk-7.3.26-6721971405.commit-c9b44f2.tgz"
  • To test with npx init

    export SDK_COMMANDS="https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/feat/update-range-input/dcl-sdk-commands-7.3.26-6721971405.commit-c9b44f2.tgz"
    npx $SDK_COMMANDS init
  • The @dcl/inspector package can be tested by visiting this url

    • Or by installing it via NPM
    npm install "https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/feat/update-range-input/@dcl/inspector/dcl-inspector-7.3.26-6721971405.commit-c9b44f2.tgz"
  • The /changerealm command to test test in-world

    /changerealm https://sdk-team-cdn.decentraland.org/ipfs/feat/update-range-input-e2e
    
  • You can preview this build entering:
    https://playground.decentraland.org/?sdk-branch=feat/update-range-input

@codecov
Copy link

codecov bot commented Oct 30, 2023

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (3cbb4dd) 69.46% compared to head (84d9641) 69.42%.

Additional details and impacted files
@@                  Coverage Diff                   @@
##           feat/ui-components     #815      +/-   ##
======================================================
- Coverage               69.46%   69.42%   -0.05%     
======================================================
  Files                     413      415       +2     
  Lines                   13311    13319       +8     
  Branches                 1729     1731       +2     
======================================================
  Hits                     9247     9247              
- Misses                   3836     3842       +6     
- Partials                  228      230       +2     
Files Coverage Δ
...cl/inspector/src/components/ui/RangeField/index.ts 0.00% <ø> (ø)
packages/@dcl/inspector/src/components/ui/index.ts 0.00% <0.00%> (ø)
.../inspector/src/components/ui/ErrorMessage/index.ts 0.00% <0.00%> (ø)
...cl/inspector/src/components/ui/RangeField/types.ts 0.00% <0.00%> (ø)
.../inspector/src/components/ui/ErrorMessage/types.ts 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cyaiox cyaiox requested a review from cazala October 30, 2023 21:29
@cyaiox cyaiox force-pushed the feat/update-range-input branch from 4d4a286 to 04caf47 Compare October 31, 2023 20:47
@cyaiox cyaiox force-pushed the feat/ui-components branch from ef167b5 to 65b6e8e Compare October 31, 2023 22:09
@cyaiox cyaiox force-pushed the feat/update-range-input branch from 04caf47 to ce58537 Compare October 31, 2023 22:15
@cyaiox cyaiox force-pushed the feat/update-range-input branch from ce58537 to 84d9641 Compare November 1, 2023 15:56
@cyaiox cyaiox merged commit fee5b4f into feat/ui-components Nov 1, 2023
8 of 10 checks passed
@cyaiox cyaiox deleted the feat/update-range-input branch November 1, 2023 16:15
cyaiox added a commit that referenced this pull request Nov 3, 2023
* feat: Refactor TextField component

* feat: Update RangeField component

* feat: Update RangeField usage component

* fix: Validate range value

* fix: Update local value with the prop
cyaiox added a commit that referenced this pull request Nov 8, 2023
* feat: Refactor TextField component

* feat: Update RangeField component

* feat: Update RangeField usage component

* fix: Validate range value

* fix: Update local value with the prop
cyaiox added a commit that referenced this pull request Nov 9, 2023
* Squashed commit of the following:

commit 62c1a6a1f1e94e62ec6bc3794296f20ef7b888b8
Author: Gabriel Diaz <[email protected]>
Date:   Mon Oct 23 18:30:51 2023 -0300

    fix: Inputs overflow on small sidebar

commit 4f31efbd19508a05cbc8c3f6300eebe364d1b3dd
Author: Gabriel Diaz <[email protected]>
Date:   Fri Oct 20 19:02:28 2023 -0300

    fix: Update CheckboxField css

commit 83330e0df7cdc5bc302f43e986373ad4ec4a4e9c
Author: Gabriel Diaz <[email protected]>
Date:   Fri Oct 20 19:02:13 2023 -0300

    feat: Update references to TextField and CheckboxField

commit 92ae7002cd4bf3a6e9d012fee5ade51c996e32b7
Author: Gabriel Diaz <[email protected]>
Date:   Fri Oct 20 18:59:07 2023 -0300

    feat: Update css var colors

commit 72c6da708da70f6f25570e8eb568b4becbace278
Author: Gabriel Diaz <[email protected]>
Date:   Fri Oct 20 18:56:58 2023 -0300

    feat: Add Checkbox field

commit 8d45b92589aac368ab3b1d9d08a19ce5e1cce84b
Author: Gabriel Diaz <[email protected]>
Date:   Fri Oct 20 18:50:59 2023 -0300

    feat: Update TextField color vars

commit 4f83571157a0c02a20f80d674bb5f1d221ebce0c
Author: Gabriel Diaz <[email protected]>
Date:   Thu Oct 19 22:16:16 2023 -0300

    feat: Refactor TextField component

    	new file:   packages/@dcl/inspector/src/components/ui/TextField/TextField.tsx

* feat: Update Container component styles (#813)

* feat: WalletField component (#817)

* feat: Add ethereum isAddress util method

* feat: Add WalletField util component

* feat: Add FileUploadField (#816)

* feat: Add FileUploadFile component

* fix: TextField placeholder color

* feat: Use the FileUploadField component for the gltf component

* feat: Update Dropdown component (#806)

* feat: Add text-primary color var

* refactor: Dropdown component

* fix: Dropdown styles

* feat: Use new dropdown UI component

* fix: Dropdown type

* fix: Elements margin

* fix: Dropdown text-wrap

* fix: Add a minFlex size to the Components Panel

* fix: Remove Unrequired Property

* refactor: Move method to a utils file

* refactor: Compare selected value with options

* fix: Avoid select an option when dragging/scrolling

* fix: Option border styles

* fix: Options min-width

* feat: Add search in dropdowns

* fix: styles

* feat: Add Inspector EntityDropdown Field (#811)

* feat: Create EntityDropdownField

* feat: Update Option component to have a minWidth based on the options

* feat: Add util hook to get components id from entities

* refactor: Use EntityField in Triggers components

* fix: Remove unused method

* fix: Dropdown min width

* feat: Update RangeField component (#815)

* feat: Refactor TextField component

* feat: Update RangeField component

* feat: Update RangeField usage component

* fix: Validate range value

* fix: Update local value with the prop

* feat: Add Inspector Hybrid Field (#820)

* feat: Use new dropdown UI component

* feat: Update Option component to have a minWidth based on the options

* fix: Remove unused method

* feat: Add HybridField component

* fix: Update TextField type prop

* feat: Update dropdown styles

* fix: Option Styles

* fix: Dropdown dynamic width

* fix: Dropdown width

* fix: Dropdown disabled and empty styles

* fix: Range Field styles (#825)

* fix: RangeField styles

* fix: RangeField native outline style

* feat: Color Field component (#824)

* feat: Update Option component to have a minWidth based on the options

* fix: Remove unused method

* feat: Add ColorPicker component

* feat: Add leftContent property to the TextField

* feat: Update HybridField to use new ColorPicker component

* feat: Refactor ColorField to use the HybridField component

* feat: Update references

* feat: Export Color components

* fix: Inspector component styles (#826)

* feat: Update Container title font-size

* fix: Dropdown empty width

* feat: Update container right-content slot

* fix: MoreOptions not closing when clicking outside

* refactor: Container component

* feat: Refactor remove context menu for containers

* fix: Update selected entity title size

* feat: Update panels min size and default size

* feat: Remove unused hoc withContextMenu

* feat: TextArea component (#818)

* refactor: Move InfoTooltip component to ui folder

* feat: Add TextArea component

* feat: Update InfoTooltip component to show default icons

* feat: Update InfoTooltip type used by components

* fix: InfoTooltip styles

* fix: Remove property

* refactor: Use ErrorMessage component

* refactor: Update component classes

* fix: Inspector component styles (#829)

* fix: Remove panel border color when hovering

* fix: Add border-radius to AddButton

* feat: Add dropdown box-shadown

* fix: Decrease add button margin-top

* fix: Dropdown label weight

* fix: Dropdown option font-size

* feat: Set default gaps for contents with fields

* fix: Dropdown search empty message (#831)

* fix: Inspector FileUploadField (#832)

* fix: Upload files using the file explorer

* feat: Update accepted file formats

* fix: styles

* chore: Update package-lock

* fix: Dropdown placeholder

* fix: test snapshots package-lock

* fix: FileUploadField component

* fix: Test import reference

* fix: Remove console.log
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant