Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add: png file thumbnails #812

Merged
merged 1 commit into from
Nov 8, 2023
Merged

add: png file thumbnails #812

merged 1 commit into from
Nov 8, 2023

Conversation

nicoecheza
Copy link
Contributor

@nicoecheza nicoecheza commented Oct 27, 2023

🤖 Generated by Copilot at 1aa5f08

This pull request enhances the AssetPreview component to support different asset types and improve the layout and performance. It adds CSS rules, subcomponents, and logic to render and capture gltf and png assets using the WearablePreview and canvas elements. It also modifies the AssetPreview.tsx and AssetPreview.css files.

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Oct 27, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: e7e92ee
Status: ✅  Deploy successful!
Preview URL: https://63fdb354.js-sdk-toolchain.pages.dev
Branch Preview URL: https://add-png-thumbnails.js-sdk-toolchain.pages.dev

View logs

@github-actions
Copy link
Contributor

github-actions bot commented Oct 27, 2023

Test this pull request

  • The @dcl/sdk package can be tested in scenes by running

    npm install "https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/add/png-thumbnails/dcl-sdk-7.3.28-6801899867.commit-8b6b961.tgz"
  • To test with npx init

    export SDK_COMMANDS="https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/add/png-thumbnails/dcl-sdk-commands-7.3.28-6801899867.commit-8b6b961.tgz"
    npx $SDK_COMMANDS init
  • The @dcl/inspector package can be tested by visiting this url

    • Or by installing it via NPM
    npm install "https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/add/png-thumbnails/@dcl/inspector/dcl-inspector-7.3.28-6801899867.commit-8b6b961.tgz"
  • The /changerealm command to test test in-world

    /changerealm https://sdk-team-cdn.decentraland.org/ipfs/add/png-thumbnails-e2e
    
  • You can preview this build entering:
    https://playground.decentraland.org/?sdk-branch=add/png-thumbnails

@codecov
Copy link

codecov bot commented Oct 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c23394d) 70.55% compared to head (afff4af) 70.55%.

❗ Current head afff4af differs from pull request most recent head e7e92ee. Consider uploading reports for the commit e7e92ee to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #812   +/-   ##
=======================================
  Coverage   70.55%   70.55%           
=======================================
  Files         399      399           
  Lines       13128    13128           
  Branches     1723     1723           
=======================================
  Hits         9262     9262           
  Misses       3652     3652           
  Partials      214      214           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nicoecheza nicoecheza force-pushed the add/png-thumbnails branch 3 times, most recently from d02d046 to 57aac3b Compare October 31, 2023 16:44
@nicoecheza nicoecheza enabled auto-merge (squash) November 8, 2023 15:30
@nicoecheza nicoecheza merged commit eb1b853 into main Nov 8, 2023
7 of 8 checks passed
@nicoecheza nicoecheza deleted the add/png-thumbnails branch November 8, 2023 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants