Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add: basic shortcuts #802

Merged
merged 1 commit into from
Nov 8, 2023
Merged

add: basic shortcuts #802

merged 1 commit into from
Nov 8, 2023

Conversation

nicoecheza
Copy link
Contributor

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Oct 24, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 6f84d75
Status: ✅  Deploy successful!
Preview URL: https://4b40bc16.js-sdk-toolchain.pages.dev
Branch Preview URL: https://add-shortcuts.js-sdk-toolchain.pages.dev

View logs

@github-actions
Copy link
Contributor

github-actions bot commented Oct 24, 2023

Test this pull request

  • The @dcl/sdk package can be tested in scenes by running

    npm install "https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/add/shortcuts/dcl-sdk-7.3.28-6798577738.commit-5b2d515.tgz"
  • To test with npx init

    export SDK_COMMANDS="https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/add/shortcuts/dcl-sdk-commands-7.3.28-6798577738.commit-5b2d515.tgz"
    npx $SDK_COMMANDS init
  • The @dcl/inspector package can be tested by visiting this url

    • Or by installing it via NPM
    npm install "https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/add/shortcuts/@dcl/inspector/dcl-inspector-7.3.28-6798577738.commit-5b2d515.tgz"
  • The /changerealm command to test test in-world

    /changerealm https://sdk-team-cdn.decentraland.org/ipfs/add/shortcuts-e2e
    
  • You can preview this build entering:
    https://playground.decentraland.org/?sdk-branch=add/shortcuts

@codecov
Copy link

codecov bot commented Oct 24, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9e4d6b3) 70.55% compared to head (6f84d75) 70.55%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #802   +/-   ##
=======================================
  Coverage   70.55%   70.55%           
=======================================
  Files         399      399           
  Lines       13128    13128           
  Branches     1723     1723           
=======================================
  Hits         9262     9262           
  Misses       3652     3652           
  Partials      214      214           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

packages/@dcl/inspector/package.json Outdated Show resolved Hide resolved
@nicoecheza nicoecheza enabled auto-merge (squash) November 8, 2023 15:30
@nicoecheza nicoecheza merged commit c23394d into main Nov 8, 2023
10 checks passed
@nicoecheza nicoecheza deleted the add/shortcuts branch November 8, 2023 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add key bindings for Undo / Redo actions
2 participants