Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serverless Multiplayer #790

Merged
merged 37 commits into from
Dec 11, 2023
Merged

Serverless Multiplayer #790

merged 37 commits into from
Dec 11, 2023

Conversation

gonpombo8
Copy link
Contributor

@gonpombo8 gonpombo8 commented Oct 16, 2023

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Oct 16, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 79ad7b8
Status: ✅  Deploy successful!
Preview URL: https://6234c6be.js-sdk-toolchain.pages.dev
Branch Preview URL: https://feat-comms-sync.js-sdk-toolchain.pages.dev

View logs

@github-actions
Copy link
Contributor

github-actions bot commented Oct 16, 2023

Test this pull request

  • The @dcl/sdk package can be tested in scenes by running

    npm install "https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/feat/comms-sync/dcl-sdk-7.3.32-7170371482.commit-9b9888b.tgz"
  • To test with npx init

    export SDK_COMMANDS="https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/feat/comms-sync/dcl-sdk-commands-7.3.32-7170371482.commit-9b9888b.tgz"
    npx $SDK_COMMANDS init
  • The @dcl/inspector package can be tested by visiting this url

    • Or by installing it via NPM
    npm install "https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/feat/comms-sync/@dcl/inspector/dcl-inspector-7.3.32-7170371482.commit-9b9888b.tgz"
  • The /changerealm command to test test in-world

    /changerealm https://sdk-team-cdn.decentraland.org/ipfs/feat/comms-sync-e2e
    
  • You can preview this build entering:
    https://playground.decentraland.org/?sdk-branch=feat/comms-sync

@codecov
Copy link

codecov bot commented Oct 16, 2023

Codecov Report

Attention: 274 lines in your changes are missing coverage. Please review.

Comparison is base (5f044c6) 67.66% compared to head (79ad7b8) 66.67%.

Files Patch % Lines
packages/@dcl/sdk/src/network/utils.ts 0.00% 45 Missing and 4 partials ⚠️
packages/@dcl/sdk/src/network/entities.ts 0.00% 42 Missing and 6 partials ⚠️
...ackages/@dcl/sdk/src/network/binary-message-bus.ts 0.00% 45 Missing and 2 partials ⚠️
packages/@dcl/sdk/src/network/message-bus-sync.ts 0.00% 35 Missing and 2 partials ⚠️
packages/@dcl/ecs/src/systems/crdt/index.ts 64.10% 26 Missing and 2 partials ⚠️
packages/@dcl/sdk/src/network/filter.ts 0.00% 21 Missing and 6 partials ⚠️
packages/@dcl/sdk/src/network/state.ts 0.00% 25 Missing and 2 partials ⚠️
packages/@dcl/sdk/src/network/index.ts 0.00% 6 Missing ⚠️
packages/@dcl/sdk/src/message-bus.ts 0.00% 3 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #790      +/-   ##
==========================================
- Coverage   67.66%   66.67%   -0.99%     
==========================================
  Files         480      493      +13     
  Lines       14424    14803     +379     
  Branches     1846     1913      +67     
==========================================
+ Hits         9760     9870     +110     
- Misses       4378     4623     +245     
- Partials      286      310      +24     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gonpombo8 gonpombo8 changed the title add sync transport via comms [wip] add sync transport via comms Oct 25, 2023
@gonpombo8 gonpombo8 changed the title [wip] add sync transport via comms add sync transport via comms Dec 7, 2023
@gonpombo8 gonpombo8 changed the title add sync transport via comms Serverless Multiplayer Dec 7, 2023
@gonpombo8 gonpombo8 marked this pull request as ready for review December 7, 2023 20:42
@gonpombo8 gonpombo8 merged commit 11a2181 into main Dec 11, 2023
8 of 10 checks passed
@gonpombo8 gonpombo8 deleted the feat/comms-sync branch December 11, 2023 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant